-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension host test wait now 6 seconds to exit #154515
Comments
Is this on Windows? Does not seem to happen in our CI with integration tests: Maybe related to a specific test? |
@dbaeumer can you provide some steps to repro the issue, thanks! |
Repository: https://github.com/microsoft/vscode-languageserver-node.git
|
Unable to repro the issue on my machine
|
@dbaeumer can you try again, latest insiders contain some fix for the utility process so it might be fixed with it. Also, fwiw I couldn't repro the issue with older insiders version as well. |
Tested it today and it still shows up. What I forgot to mention is that I see this using WSL2 under Windows. |
@deepak1556 if you want we can have a look together on my machine. |
This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines. Happy Coding! |
I will first try your repro under WSL and if I cannot repro, we can debug on your machine. |
Interestingly, scanning some smoke test logs, I often come across this message from the
Full log:
I wonder how we can figure out what the condition is that triggers it and maybe add more logging? |
I can reproduce locally that on Linux running smoke tests shows the Steps to reproduce:
You can then I cannot reproduce this on macOS, so I suspect a Linux only issue. Interestingly when I test on Linux against stable I can see one instance of test hanging on shutdown as well, somewhat 6 seconds, but I see no log message. So maybe we only log this message when utility process is enabled and we actually had this issue already previously? |
Any progress on this. Still seeing this when running my tests. |
Addressed in #164882. Verified #154515 (comment) and #154515 (comment) in respective setups. |
I see this now when running my extension host tests:
Is there something I need to do in my tests. This didn't happen before.
The text was updated successfully, but these errors were encountered: