Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow me to disable debug status bar treatment #155294

Closed
jrieken opened this issue Jul 15, 2022 · 12 comments · Fixed by #168513
Closed

Allow me to disable debug status bar treatment #155294

jrieken opened this issue Jul 15, 2022 · 12 comments · Fixed by #168513
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jul 15, 2022

I am becoming a power-user of our debugger (yeah, finally). This means that most of my "VS Code time" I have some kind of debuggee running or connected. So, I am seeing the ugly orange debug status bar treatment a lot. I don't like it and for me it's enough to see the activitybar icon decorations. So, pretty please give me an option to disable this

@roblourens
Copy link
Member

Is it enough to set statusBar.debuggingBackground in workbench.colorCustomizations? Or do you think we need a dedicated setting?

@roblourens roblourens added the info-needed Issue requires more information from poster label Jul 15, 2022
@jrieken
Copy link
Member Author

jrieken commented Jul 15, 2022

A dedicated setting because the color customizations don't allow to reference another color (AFAIK)

@jrieken jrieken removed the info-needed Issue requires more information from poster label Jul 15, 2022
@roblourens roblourens added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 15, 2022
@roblourens roblourens added this to the Backlog milestone Jul 15, 2022
@roblourens roblourens added the good first issue Issues identified as good for first-time contributors label Jul 15, 2022
@roblourens
Copy link
Member

Just need a setting checked here

this.enabled = isStatusbarInDebugMode(this.debugService.state, this.debugService.getViewModel().focusedSession);

@shaiguelman
Copy link

Can I work on this?

@gjsjohnmurray
Copy link
Contributor

A dedicated setting because the color customizations don't allow to reference another color (AFAIK)

A good use case for #56855 (comment)

@roblourens
Copy link
Member

@KoushikSahu Someone had already expressed interest in this, please let them take it next time. I'll look at your PR but don't have time in July due to vacation, I'll review it in August.

@KoushikSahu
Copy link

@KoushikSahu Someone had already expressed interest in this, please let them take it next time. I'll look at your PR but don't have time in July due to vacation, I'll review it in August.

Apologies for the inconvenience caused. I will take into account any prior interests from here on.

@utkarsh867
Copy link

Is this issue still active? I'd like to have this feature too! So if no one is taking it, I'm more than happy to give it a shot :)

@KoushikSahu
Copy link

Is this issue still active? I'd like to have this feature too! So if no one is taking it, I'm more than happy to give it a shot :)

Not getting the time to work on this. Please go ahead and take this up if you want to.

@weartist
Copy link
Contributor

Can I also add pr for this question? There seems to be no progress

@modeware
Copy link

modeware commented Nov 20, 2022

Are we talking about the bottom pink colour bar? A dedicated setting to change that color?
If no progress has been made, I would like to explore this.
Just a few questions -
--- Do I need to understand - what disposables are doing, how electron works etc. to get started with this issue? Like what kind of prerequisite is needed?
cc: @roblourens

image

@antonioprudenzano
Copy link
Contributor

I don't see any recent activity on this so i'm linking a PR, waiting for review.

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 12, 2022
@rzhao271 rzhao271 modified the milestones: Backlog, January 2023 Dec 29, 2022
@roblourens roblourens added the verification-needed Verification of issue is requested label Jan 24, 2023
@connor4312 connor4312 added the verified Verification succeeded label Jan 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet