Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings option for status bar decoration in debugging session #155522

Closed
wants to merge 1 commit into from
Closed

Add settings option for status bar decoration in debugging session #155522

wants to merge 1 commit into from

Conversation

KoushikSahu
Copy link

@KoushikSahu KoushikSahu commented Jul 18, 2022 •
edited

This PR fixes #155294

cc: @roblourens

@KoushikSahu KoushikSahu force-pushed the feat/155294 branch 2 times, most recently from 22aff22 to d272854 Compare July 18, 2022 17:45
@KoushikSahu
Copy link
Author

@roblourens Can you please review my PR? Also I believe you would be able to provide necessary permission to run the remaining gh actions.

@roblourens roblourens added this to the August 2022 milestone Jul 19, 2022
@KoushikSahu
Copy link
Author

@roblourens thanks for the review. Let me know if this works.

roblourens
roblourens requested changes Aug 5, 2022
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this needs a little more. update() should run immediately when the setting changes. I should be able to toggle this even while debugging and see the effect. And currently if I disable it while in a debugging session, then the color never goes away. So this.enabled should always be set to something when update runs, instead of skipping it. Please test it a little bit like this and make sure nothing weird can happen.

@KoushikSahu
Copy link
Author

Actually, this needs a little more. update() should run immediately when the setting changes. I should be able to toggle this even while debugging and see the effect. And currently if I disable it while in a debugging session, then the color never goes away. So this.enabled should always be set to something when update runs, instead of skipping it. Please test it a little bit like this and make sure nothing weird can happen.

@roblourens Yeah I didn't test it this way. I'll try and figure this out.

@KoushikSahu
Copy link
Author

Actually, this needs a little more. update() should run immediately when the setting changes. I should be able to toggle this even while debugging and see the effect. And currently if I disable it while in a debugging session, then the color never goes away. So this.enabled should always be set to something when update runs, instead of skipping it. Please test it a little bit like this and make sure nothing weird can happen.

@roblourens So I made sure that the this.enable is always set to some boolean when update function is called. The behaviour I got was the same as before. During the debugging session if user changes the setting then the color is not reflected immediately but after performing some debugging action (like step over, step up ...).

@roblourens
Copy link
Member

You can listen to configurationService.onDidChangeConfiguration and update when that setting is changed.

@KoushikSahu
Copy link
Author

Been busy this month. I have time available now. I will be working on the required code changes from now.

@lszomoru lszomoru modified the milestones: September 2022, October 2022 Sep 30, 2022
@jrieken
Copy link
Member

jrieken commented Oct 5, 2022

Did this go stale? Iff so I'll work on a PR

@KoushikSahu
Copy link
Author

Did this go stale? Iff so I'll work on a PR

Not getting the time to work on this. Sorry for the inconvenience. Please take this issue up.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens requested changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.

Allow me to disable debug status bar treatment
4 participants
@KoushikSahu @roblourens @jrieken @lszomoru