Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y_VisualStudioCodeClient_Customizations and settings_Keyboard shortcuts_Screenreader: Key binding status message "1 existing command has this key bending" is not announced by screen reader #159432

Closed
v-inanda opened this issue Aug 29, 2022 · 5 comments · Fixed by #159746
Closed

A11y_VisualStudioCodeClient_Customizations and settings_Keyboard shortcuts_Screenreader: Key binding status message "1 existing command has this key bending" is not announced by screen reader #159432

v-inanda opened this issue Aug 29, 2022 · 5 comments · Fixed by #159746
Assignees
@sandy081
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-sla Accessibility issue which have to be fixed or lowered severity based on process bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders keybindings-editor Keybinding editor issues verified Verification succeeded
Milestone
September 2022

Comments

@v-inanda
Copy link

v-inanda commented Aug 29, 2022 •
edited

GitHub Tags:

#A11yMAS; #A11yWCAG2.1; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2022; #WCAG4.1.3; #NVDA; #ScreenReader; #Narrator; #Closed

Environment and OS details:

Visual Studio Code Version: 1.70.2 (user setup)
Windows 11 Pro version 21H2 (OS Build 22000.856)

Repro Steps:

  1. Turn on NVDA
  2. Open Visual studio code editor.
  3. Tab till setting icon and Select "Keyboard shortcuts options"
  4. Verify that Key bending status message "1 existing command has this key bending" is announced by screen reader or not.

Actual Result:

Key bending status message "1 existing command has this key bending" is not announced by NVDA/Narrator screen readers.

Expected Result:

NVDA/Narrator should announce the status message "1 existing command has this key bending"

Attachment:

NVDA

narrator
@weinand weinand assigned isidorn and unassigned weinand Aug 29, 2022
@isidorn isidorn changed the title A11y_VisualStudioCodeClient_Customizations and settings_Keyboard shortcuts_Screenreader: Key bending status message "1 existing command has this key bending" is not announced by screen reader. Key binding status message "1 existing command has this key bending" is not announced by screen reader Aug 29, 2022
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues keybindings-editor Keybinding editor issues a11ymas Issue from accessibility team accessibility-sla Accessibility issue which have to be fixed or lowered severity based on process labels Aug 29, 2022
@isidorn isidorn assigned sandy081 and unassigned isidorn Aug 29, 2022
@isidorn
Copy link
Contributor

isidorn commented Aug 29, 2022

@sandy081 can we just do an aria alert when there are existing keybindings?
This issue we have to fix since it is severity 2, though it sounds law hanging.

@v-inanda v-inanda changed the title Key binding status message "1 existing command has this key bending" is not announced by screen reader A11y_VisualStudioCodeClient_Customizations and settings_Keyboard shortcuts_Screenreader: Key binding status message "1 existing command has this key bending" is not announced by screen reader Aug 30, 2022
@sandy081 sandy081 added this to the September 2022 milestone Sep 1, 2022
sandy081 added a commit that referenced this issue Sep 1, 2022
@sandy081
fix #159432
203f2a6
@sandy081 sandy081 mentioned this issue Sep 1, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Sep 1, 2022
sandy081 added a commit that referenced this issue Sep 1, 2022
@sandy081
fix #159432 (#159746)
f401257
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 2, 2022
@v-inanda
Copy link
Author

v-inanda commented Sep 6, 2022

@sandy081 PO should not close the bug. Only trusted tester closes the bug.
This bug is not fixed. So, please provide the reason for closing the bug. Thanks

@isidorn
Copy link
Contributor

isidorn commented Sep 6, 2022

@v-inanda make sure to use VS Code insiders https://code.visualstudio.com/insiders/

@v-inanda
Copy link
Author

v-inanda commented Sep 8, 2022

Issue is fixed. So,Closing the bug.
Screen-Recording-3

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Sep 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-sla Accessibility issue which have to be fixed or lowered severity based on process bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders keybindings-editor Keybinding editor issues verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

fix #159432 microsoft/vscode
6 participants
@weinand @isidorn @sandy081 @v-inanda @VSCodeTriageBot and others