Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment card: rendering of label action is broken with 1.71 #164288

Closed
laurentlb opened this issue Oct 21, 2022 · 2 comments
Closed

Comment card: rendering of label action is broken with 1.71 #164288

laurentlb opened this issue Oct 21, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues verified Verification succeeded
Milestone

Comments

@laurentlb
Copy link
Contributor

laurentlb commented Oct 21, 2022

Does this issue occur when all extensions are disabled?: Yes/No

We were using a command under comments/commentThread/title to show a label action on the comments card. With the update from 1.70.2 to 1.71.2, the rendering is broken.

Before:
image

After:
image

The command is defined in the package.json using:

      "comments/commentThread/title": [
        {
          "command": "critique.markDraftResolved",
          "group": "main",
          "when": "commentThread =~ /<draft><unresolved>/"
        },

Granted, it's probably not a very used feature, but we found it useful until we can show more buttons in the comments card.

Playing with the Chrome Devtools, I can fix the rendering by commenting the display: flex; here (it seems to be the main difference between 1.70 and 1.71):
image

@laurentlb
Copy link
Contributor Author

cc @alexr00

@alexr00
Copy link
Member

alexr00 commented Oct 21, 2022

Looks like this was done to try to fix the size of the button: b77a891

@jrieken was the goal with that change to keep the button the same size as buttons with an icon?

@alexr00 alexr00 added under-discussion Issue is under discussion for relevance, priority, approach comments Comments Provider/Widget/Panel issues labels Oct 21, 2022
@alexr00 alexr00 added this to the October 2022 milestone Oct 21, 2022
alexr00 added a commit that referenced this issue Oct 25, 2022
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 26, 2022
alexr00 added a commit that referenced this issue Oct 26, 2022
* Allow action labels to be long in comment header
Part of #164288

* Better fix
@alexr00 alexr00 closed this as completed Oct 26, 2022
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Oct 27, 2022
formigoni pushed a commit to formigoni/vscode that referenced this issue Oct 27, 2022
* Allow action labels to be long in comment header
Part of microsoft#164288

* Better fix
@jrieken jrieken added the verified Verification succeeded label Oct 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants