Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow action labels to be long in comment header #164614

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Allow action labels to be long in comment header #164614

merged 2 commits into from
Oct 26, 2022

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Oct 25, 2022

Part of #164288

@alexr00 alexr00 self-assigned this Oct 25, 2022
@alexr00 alexr00 requested a review from jrieken October 25, 2022 16:08
@alexr00
Copy link
Member Author

alexr00 commented Oct 25, 2022 •
edited
Loading

@jrieken, was it your intent with b77a891 that all menu bars not allow actions to be larger than an icon?

@VSCodeTriageBot VSCodeTriageBot added this to the October 2022 milestone Oct 25, 2022
@jrieken
Copy link
Member

jrieken commented Oct 26, 2022

@jrieken, was it your intent with b77a891 that all menu bars not allow actions to be larger than an icon?

The opposite in fact. Label-only actions should get the same layout logic as normal icons - take the width they need and be properly aligned. I believe you suffer from setting an explicit width here:

vscode/src/vs/workbench/contrib/comments/browser/media/review.css

Line 361 in 84a929b

width: 16px;

jrieken
jrieken reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not setting explicit widths might be a better fix here

@alexr00
Copy link
Member Author

alexr00 commented Oct 26, 2022

Glad I checked. Removing the width does seem like a better fix.

@alexr00 alexr00 merged commit 55ebe5e into main Oct 26, 2022
@alexr00 alexr00 deleted the alexr00/longLabels branch October 26, 2022 14:55
formigoni pushed a commit to formigoni/vscode that referenced this pull request Oct 27, 2022
@alexr00 @formigoni
Allow action labels to be long in comment header (microsoft#164614)
6e7f566 
* Allow action labels to be long in comment header
Part of microsoft#164288

* Better fix
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexr00 @jrieken @VSCodeTriageBot