Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No command localizations load if any command title points to an invalid package.nls.json entry #164630

Closed
karrtikr opened this issue Oct 25, 2022 · 0 comments · Fixed by #165096
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link
Contributor

karrtikr commented Oct 25, 2022

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.72.2 (user setup)
OS: Windows_NT x64 10.0.22518

Steps to Reproduce:

  1. Use Python extension for example. Have an entry in package.json for a command but misspell the title part:
{
    "category": "Python",
    "command": "python.setInterpreter",
    "title": "%python.command.python.doesNotExist.title%"
},
  1. None of the other localizations load:

image

Issue observed in Python extension: microsoft/vscode-python#20063 and Jupyter: microsoft/vscode-jupyter#11600

cc/ @TylerLeonhardt

@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) labels Oct 31, 2022
@TylerLeonhardt TylerLeonhardt added this to the November 2022 milestone Oct 31, 2022
TylerLeonhardt added a commit that referenced this issue Nov 1, 2022
* The true fix

* some code clean up
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 1, 2022
@connor4312 connor4312 added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants