Fix #164630 #165096
Merged
Fix #164630 #165096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Nov 1, 2022
| @@ -16,6 +16,7 @@ export function localizeManifest(extensionManifest: IExtensionManifest, translat | |||
| try { | |||
| replaceNLStrings(extensionManifest, translations, fallbackTranslations); | |||
| } catch (error) { | |||
| console.error(error?.message ?? error); | |||
There was a problem hiding this comment.
Just checking that this is supposed to be left?
There was a problem hiding this comment.
Yes. Because I didn't have that, I didn't catch this issue, so I'm surfacing it
roblourens
approved these changes
Nov 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to review one commit at a time which may be easier.
Fixes #164630