Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaneView calls renderBody even when the pane is collapsed #164662

Closed
mjbvz opened this issue Oct 26, 2022 · 2 comments
Closed

PaneView calls renderBody even when the pane is collapsed #164662

mjbvz opened this issue Oct 26, 2022 · 2 comments
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug perf verified Verification succeeded
Milestone
November 2022

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 26, 2022 •
edited
Loading

Repo

  1. In explorer, collapse the timeline view
  2. Create a breakpoint in TimelinePane.renderBody
  3. Reload window

Bug
See the breakpoint being hit even through the contents of the timeline are not visible

This is caused by this code:

vscode/src/vs/base/browser/ui/splitview/paneview.ts

Line 252 in 84a929b

this.renderBody(this.body);

It seems to me we should try to defer this work until the view actually becomes visible
@mjbvz mjbvz added the perf label Oct 26, 2022
@mjbvz mjbvz added this to the November 2022 milestone Oct 26, 2022
@mjbvz mjbvz changed the title Panee call renderBody even when the pane is collapsed PaneView calls renderBody even when the pane is collapsed Oct 26, 2022
@sbatten sbatten mentioned this issue Nov 1, 2022
Merged
sbatten added a commit that referenced this issue Nov 1, 2022
@sbatten
only renderBody when view is visible/expanded
0798aa9 
fixes PaneView calls renderBody even when the pane is collapsed #164662
sbatten added a commit that referenced this issue Nov 1, 2022
@sbatten
only renderBody when view is visible/expanded (#165187)
8f06fd3 
fixes PaneView calls renderBody even when the pane is collapsed #164662
@mjbvz mjbvz removed their assignment Nov 2, 2022
@sbatten sbatten closed this as completed Nov 23, 2022
@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Nov 28, 2022
@sbatten
Copy link
Member

sbatten commented Nov 28, 2022

@mjbvz would you be willing to verify for completeness?

@mjbvz
Copy link
Collaborator Author

mjbvz commented Nov 29, 2022

Works great!

@mjbvz mjbvz added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug perf verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

No branches or pull requests
2 participants
@sbatten @mjbvz