only renderBody when view is visible/expanded #165187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes PaneView calls renderBody even when the pane is collapsed #164662
aeschli
approved these changes
Nov 1, 2022
joaomoreno
reviewed
Nov 1, 2022
| @@ -158,6 +159,11 @@ export abstract class Pane extends Disposable implements IView { | |||
| this.updateHeader(); | |||
|
|
|||
| if (expanded) { | |||
| if (!this._bodyRendered) { | |||
| this.renderBody(this.body); | |||
| this._bodyRendered = true; | |||
There was a problem hiding this comment.
@sbatten We should set this to true inside renderBody, not outside. Especially because renderBody is protected.
There was a problem hiding this comment.
are you suggesting to move it out into ViewPane instead? renderBody is abstract in the Pane. Even if a subclass calls this, setting it to true inside renderBody won't prevent the subclass from calling it.
There was a problem hiding this comment.
I'm suggesting making it concrete and have every subclass call super.renderBody() in their renderBody implementation first thing.
sandy081
added a commit
that referenced
this pull request
Dec 12, 2022
Revert "only renderBody when view is visible/expanded (#165187)"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PaneView calls renderBody even when the pane is collapsed #164662
cc @joaomoreno