Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tree shaking tool to identify dead code in microsoft/vscode #165092

Closed
joyceerhl opened this issue Oct 31, 2022 · 2 comments
Closed

Use tree shaking tool to identify dead code in microsoft/vscode #165092

joyceerhl opened this issue Oct 31, 2022 · 2 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@joyceerhl
Copy link
Contributor

@rebornix mentioned that we have a tree shaking tool for the Monaco editor. This issue tracks adapting the tree shaking tool to identify dead code in the microsoft/vscode repo (unlike in the Monaco editor case, dead code in the microsoft/vscode repo should simply be removed). This could give us more precise dead code results than the ts-unused exports tool.

We could probably add a CI job that runs this tool whenever a new release branch is cut and files issues for debt week, in order to avoid paying the cost of running the tool on every commit.

@joyceerhl joyceerhl added debt Code quality issues engineering VS Code - Build / issue tracking / etc. labels Oct 31, 2022
@joyceerhl joyceerhl added this to the Backlog milestone Oct 31, 2022
@joyceerhl joyceerhl assigned rebornix and joyceerhl and unassigned rebornix and joyceerhl Oct 31, 2022
@joyceerhl joyceerhl removed this from the Backlog milestone Oct 31, 2022
@joyceerhl joyceerhl removed the debt Code quality issues label Oct 31, 2022
@alexdima alexdima added this to the On Deck milestone Nov 14, 2022
@alexdima alexdima added the feature-request Request for new features or functionality label Nov 14, 2022
@jrieken jrieken added the *out-of-scope Posted issue is not in scope of VS Code label Nov 29, 2023
@VSCodeTriageBot
Copy link
Collaborator

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
@jrieken
Copy link
Member

jrieken commented Nov 29, 2023

out-of-scope but there will be a future with ESM and that enables built tools that come with module-level tree shaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

5 participants