Reduce unused exports #164938
Comments
|
Let's pause a moment and re-consider all the |
|
So, suggestion 1 is to rerun with the |
|
I also have expressed some concerns in #164934 (comment) |
|
Quick clarification here: the primary purpose of this issue is to identify unused functions and classes which aren't being picked up by the compiler because they're exported and which can be safely deleted from our sources to reduce our bundle size. A secondary benefit is to remove unused types and interfaces, e.g. anything which was exported at one point and then ceased to be referenced from other files (which more impacts compile time for dev workflows and pipeline runs, and maybe TS server analysis time, but has no direct impact on bundle size since types are erased). If you export a type or interface that is not currently actively imported, but is used in the public API of a class that you expose, then it's quite likely that you want to keep that type/interface exported and should not un-export it as part of this issue. As @jrieken pointed out there are several such false positives from this tool. From talking to @rebornix we can achieve at least the primary purpose of this issue a different way, e.g. by adapting the existing tree shaking tooling we have for Monaco to flag dead code in |
|
@joyceerhl, are we still pursuing this effort? |
|
Closing this without further action |
@rebornix and I were wondering if there is any dead code in the VS Code codebase, and one idea was to detect unused exports across the codebase, since unused variables are flagged by the compiler but unused exports are not.
I ran
ts-unused-exportson our sources and generated the following list. I've already done a pass to remove some false positives but apologies if several remain.NB: The primary purpose of this issue is to identify unused functions and classes which aren't being picked up by the compiler because they're exported and which can be safely deleted from our sources to reduce our bundle size. A secondary benefit is to remove unused types and interfaces, e.g. anything which was exported at one point and then ceased to be referenced from other files (which more impacts compile time for dev workflows and pipeline runs, and maybe TS server analysis time, but has no direct impact on bundle size since types are erased).
If you export a type or interface that is not currently actively imported, but is used in the public API of a class that you expose, then it's quite likely that you want to keep that type/interface exported and need not un-export it as part of this issue.
Please feel free to remove your assignment if you find that this isn't valuable.
SelectKernelReturnArgsIBreadcrumbsWidgetStylesInvisibleSizingIResizeEventSplitSizingInvisibleSizingRevivedmapPagerValueCallbackICommandMenuOptionsIEditorActionContextMenuOptions_CSS_MAPIGetWordAtTextConfigCodeLensCacheIDecorationIdCallbackMarkerCoordinatectxHasSymbolsctxReferenceSearchVisibleSelectionEventRenameInputFieldResultTokenTransformableMarkerOneSnippetISnippetSessionInsertOptionsIReadClipboardTextICompletionStatsMemItemMemModeSuggestMemoryServiceSuggestContentWidgetISuggestionTemplateDataViewZoneDelegateOverlayWidgetDelegatecreateDiffNavigatorgetModelMarkersgetModelonDidChangeModelLanguageregisteronLanguagesetLanguageConfigurationIColorsILoadStatusICommandActionToggleInfoIDropdownWithDefaultActionViewItemOptionsDropdownWithDefaultActionViewItemIWorkbenchToolBarOptionsIToolBarRenderOptionsIMenuWorkbenchToolBarOptionsIMenuRegistryChangeEventIMenuRegistryICommandICommandRegistryAbstractContextKeyServiceNodeIV8CallFrameIComputedNodeISourceLocationCdpPositionTickInfoINodeILocationIAnnotationLocationIProfileNodeICpuProfileRawSampleDatacreateIScriptUrlClassifierCategoryAnalysisIBreadcrumbsWidgetStyleOverridesdefaultBreadcrumbsStylesIdleCheckingForUpdatesDownloadingDownloadedUpdatingReadyExtHostDebugConsoleIExtHostDocumentsAndEditorsDeltaTunnelIConsolePatchFnMarketplaceExtensionBreadcrumbsServiceSelectEventFileSorterCheckedStatesICheckableDocumentSymbolItemINotebookRawDatacreateTestNotebookEditorSearchEditorDataextractSearchQueryFromModelextractSearchQueryFromLinesISimpleModelvalidateTerminalNameallWalkthroughsHiddenContextIExtensionDevOptionsILanguageStatusProviderIMemoryInfoFiltersAssignmentServiceIWalkthroughStepIStartEntryIPropertyDataStrictPropertyCheckerStrictPropertyCheckErrorPropertiesMeasurementsExtHostTelemetryLoggerEditorReplacementIResourceMergeEditorInputSideIMatchOptionsTimelineExcludeSourcesembedderIdentifierContextIWelcomePageStartEntryHasMultipleNewFileEntrieswalkthroughMetadataConfigurationKeyWalkthroughMetaDataTypeIWalkthroughIWalkthroughLooseIWalkthroughStepWalkthroughsServiceBuiltinGettingStartedStepBuiltinGettingStartedCategoryBuiltinGettingStartedStartEntryOtherTestEditorWorkspaceTrustRequestButtonExtHostSCMInputBoxIExtHostTimelinemaxSizeSCMActionButtonTimelineFollowActiveEditorContextTimelineElementTemplateTimelineIdentityProviderTimelineKeyboardNavigationLabelProviderTimelineListVirtualDelegatetoKeyTimelineSourceWorkspaceTrustRequestServiceThe text was updated successfully, but these errors were encountered: