Inlay hint location links goto definition goes to the nearest symbol

[HKalbasi]

Does this issue occur when all extensions are disabled?: No

• VS Code Version: 1.73.1
• OS Version: Pop!_OS 22.04 LTS

Steps to Reproduce:

It should use the location data which the language server provides if I ctrl+click on the linked part, but instead it runs go to definition for the nearest token (which is colored in addition to the inlay hint part which is under cursor).

[VSCodeTriageBot]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[HKalbasi]

It remains.

[HKalbasi]

cc #129528 @jrieken

[VSCodeTriageBot]

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

[HKalbasi]

Steps to reproduce:

1. Use a language server that supports location links in inlay hints
2. Ctrl+click on one of the links

It will go to the definition of nearest token (the default behaviour of clicking on inlay hints) instead of the link target. It also should not make the nearest token blue and only blue the link part.

[HKalbasi]

Please tell me if there is anything else missing.

[HKalbasi]

I can reproduce it in monaco playground as well with this code:

monaco.languages.register({
	id: 'myLang'
});

monaco.editor.create(document.getElementById('container'), {
	value: `
tokenWithNoDefinition
tokenWithDefinition

targetOfToken
targetOfInlayHint
    `,
	language: 'myLang',
	colorDecorators: true
});

monaco.languages.registerDefinitionProvider('myLang', {
    provideDefinition: (model, position) => {
        if (position.lineNumber === 3) {
            return {
                range: new monaco.Range(5, 1, 5, 14),
                uri: model.uri,
            };
        }
    },
});

const inlayLabel = (model) => [
    {
        label: 'Unlinked<',
    },
    {
        label: 'linked',
        location: {
            range: new monaco.Range(6, 1, 6, 14),
            uri: model.uri,
        }
    },
    {
        label: '>Unlinked2',
    },
];

monaco.languages.registerInlayHintsProvider('myLang', {
    provideInlayHints: (model) => {
        return {
            hints: [
                {
                    label: inlayLabel(model),
                    position: new monaco.Position(2, 22),
                },
                {
                    label: inlayLabel(model),
                    position: new monaco.Position(3, 20),
                },
            ]
        };
    },
});

It creates two inlay hints but ctrl+click on either of them won't go to the targetOfInlayHint.

[jrieken]

Thanks. Code sample is the way to go 👏

[HKalbasi]

@jrieken Can you please reopen this issue? It is not fixed completely yet (#167886 (comment))

[jrieken]

Thanks for the ping. I didn't really test this. I have #169532 up for this. It should reduce confusing and make this less error prone

[HKalbasi]

Thanks! this now works correctly.

[dbaeumer]

Marking as verified due to previous comment.