Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple more pixels of separation between Accept Tab and Accept Part #172152

Closed
isidorn opened this issue Jan 24, 2023 · 4 comments · Fixed by #172388 or #172518
Closed

A couple more pixels of separation between Accept Tab and Accept Part #172152

isidorn opened this issue Jan 24, 2023 · 4 comments · Fixed by #172388 or #172518
Assignees
Labels
inline-completions insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2023

Testing #172029

I feel like the Accept Tab and Accept Part are too close. Can we give it 2 more pixel breathing room, so it is clearer these are different actions?

The separation between the other elements is fine. So ideally all other boundaries remain the same

Screenshot 2023-01-24 at 14 00 03

hediet added a commit that referenced this issue Jan 25, 2023
@hediet
Copy link
Member

hediet commented Jan 25, 2023

Before:

image

After:

image

@hediet hediet added this to the January 2023 milestone Jan 25, 2023
@hediet hediet added polish Cleanup and polish issue inline-completions labels Jan 25, 2023
@isidorn
Copy link
Contributor Author

isidorn commented Jan 25, 2023

Hmm did the first Accept move more to the right? Thus it is farther away from >
Also the ... moved farther away.

So overall I think it looks worse. My suggestion was not good. Though I was mostly concerned about the distance between the two accept actions. But I understand that coding only that case is not nice.

What do you think?

@hediet
Copy link
Member

hediet commented Jan 25, 2023

I think it looks better. The first Accept did not move, there is only more space between Accept and Accept Word and ... (4px more).

I can change this to 2px.

hediet added a commit that referenced this issue Jan 25, 2023
* Fixes #172152

* Adresses PR feedback.
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 25, 2023
@isidorn
Copy link
Contributor Author

isidorn commented Jan 25, 2023

Ok, great if you changed to 2px. 4px was too much imho :)

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 26, 2023
@hediet hediet reopened this Jan 26, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jan 26, 2023
hediet added a commit that referenced this issue Jan 26, 2023
* Fixes #172152

* Adresses PR feedback.
hediet added a commit that referenced this issue Jan 26, 2023
hediet added a commit that referenced this issue Jan 26, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
inline-completions insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants