Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New inline suggest hover uses a 2px border instead of 1px #172180

Closed
Tyriar opened this issue Jan 24, 2023 · 2 comments · Fixed by #172517
Closed

New inline suggest hover uses a 2px border instead of 1px #172180

Tyriar opened this issue Jan 24, 2023 · 2 comments · Fixed by #172517
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug inline-completions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
January 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 24, 2023

Testing #172029

image

2px has special meaning that it's "locked" while alt is held:

image

vs

image
@hediet hediet added inline-completions bug Issue identified by VS Code Team member as probable bug labels Jan 25, 2023
@hediet hediet added this to the January 2023 milestone Jan 25, 2023
hediet added a commit that referenced this issue Jan 26, 2023
@hediet
Fixes #172180
b690223
@hediet hediet mentioned this issue Jan 26, 2023
Merged
hediet added a commit that referenced this issue Jan 26, 2023
@hediet
Fixes #172180 (#172517)
806e144
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 26, 2023
davidnx pushed a commit to davidnx/vscode that referenced this issue Jan 26, 2023
@hediet
Fixes microsoft#172180 (microsoft#172517)
9419c55
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 27, 2023
@bhavyaus
Copy link
Contributor

How do I verify this using a tool? The two hovers (inline suggest hover and terminal hover) look the same to me on my devices.

@bhavyaus bhavyaus added the verification-steps-needed Steps to verify are needed for verification label Jan 27, 2023
@roblourens
Copy link
Member

I think if they look the same, it's fixed, and the terminal one should have slightly thicker borders when holding alt

@bhavyaus bhavyaus added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jan 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug inline-completions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Fixes #172180 microsoft/vscode
5 participants
@roblourens @Tyriar @hediet @bhavyaus @VSCodeTriageBot