Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing terminal link- spaces with "line x col y" not working #172302

Closed
andreamah opened this issue Jan 24, 2023 · 4 comments · Fixed by #172930
Closed

Testing terminal link- spaces with "line x col y" not working #172302

andreamah opened this issue Jan 24, 2023 · 4 comments · Fixed by #172930
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Milestone

Comments

@andreamah
Copy link
Contributor

Testing #172084
I tried the following:
/home/andrea/Documents/python-test/test.py, line 1, col 2

And it didn't identify the whole thing as a link. Is this expected?

@andreamah
Copy link
Contributor Author

I also tried
"/home/andrea/Documents/python-test/test.py", line 1, col 2 and it didn't work

@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2023

image

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-links labels Jan 26, 2023
@Tyriar Tyriar added this to the February 2023 milestone Jan 26, 2023
@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2023

On a single line works due to the fallback matcher being used:

image

@Tyriar
Copy link
Member

Tyriar commented Jan 30, 2023

This is actually harder to fix than I expected. The regex matchers get a bit confused currently when we try to be smart and include [ and , characters. A better approach to this problem may be to first search for suffixes, then check if there's a path before it, if not search for a path by itself?

Tyriar added a commit that referenced this issue Jan 30, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 1, 2023
@andreamah andreamah added the verified Verification succeeded label Feb 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants