Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGKILL terminal processes on macOS/linux #176819

Merged
merged 1 commit into from Mar 10, 2023
Merged

SIGKILL terminal processes on macOS/linux #176819

merged 1 commit into from Mar 10, 2023

Conversation

meganrogge
Copy link
Contributor

fix #174956

@meganrogge meganrogge self-assigned this Mar 10, 2023
@meganrogge meganrogge requested a review from Tyriar March 10, 2023 19:46
@meganrogge meganrogge added this to the March 2023 milestone Mar 10, 2023
@meganrogge meganrogge merged commit 686cab8 into main Mar 10, 2023
@meganrogge meganrogge deleted the merogge/sig-kill branch March 10, 2023 20:10
@rniem379349 rniem379349 mentioned this pull request Mar 12, 2023
Closed
@rsodre
Copy link

rsodre commented Mar 17, 2023

in which version will this be patched?
version 1.76.2 still not killing terminal processes

@meganrogge
Copy link
Contributor Author

1.77

@tamuratak tamuratak mentioned this pull request Mar 20, 2023
Closed
@rsodre rsodre mentioned this pull request Apr 3, 2023
Closed
@asportnoy
Copy link

Hi @meganrogge, I am on 1.77.3 (704ed70) and I can still reproduce this issue. I tested by running sleep 10; pmset sleepnow and then quit VSCode. My mac still went to sleep after 10 seconds, so the process was not stopped.

@asportnoy
Copy link

Nevermind, just saw #174956 (comment). Won't be out until v1.78.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.

extra terminal processes hanging around on restart
4 participants
@meganrogge @rsodre @asportnoy @Tyriar