Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relativeFileDirname not resolved in search command in WSL/SSH #180553

Closed
eronnen opened this issue Apr 21, 2023 · 0 comments · Fixed by #180554
Closed

relativeFileDirname not resolved in search command in WSL/SSH #180553

eronnen opened this issue Apr 21, 2023 · 0 comments · Fixed by #180554
Assignees
@andreamah
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verified Verification succeeded
Milestone
May 2023

Comments

@eronnen
Copy link
Contributor

eronnen commented Apr 21, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.77.3
  • OS Version: Windows 10.0.19044

Steps to Reproduce:

  1. use WSL/SSH
  2. define custom keybinding:
{
    "key": "ctrl+shift+g",
    "command": "workbench.action.findInFiles",
    "args": {
        "filesToInclude": ".${pathSeparator}${relativeFileDirname}",
    }
}
  1. use ctrl+shift+g in a nested directory in the workspace

Outcome:
filesToInclude field will have the full path of the directory instead of its relative path
eronnen added a commit to eronnen/vscode that referenced this issue Apr 21, 2023
@eronnen
fix file variables resolving in findInFilesCommand when using vscode-…
98944fc 
…remote microsoft#180553
@eronnen eronnen mentioned this issue Apr 21, 2023
Merged
eronnen added a commit to eronnen/vscode that referenced this issue Apr 21, 2023
@eronnen
fix file variables resolving in findInFilesCommand when using vscode-…
e5161f6 
…remote microsoft#180553
eronnen added a commit to eronnen/vscode that referenced this issue Apr 21, 2023
@eronnen
fix ${relativeFileDirname} resolving in findInFilesCommand when using…
e4f5791 
… remote microsoft#180553
@andreamah andreamah added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels May 3, 2023
@andreamah andreamah added this to the May 2023 milestone May 3, 2023
andreamah pushed a commit that referenced this issue May 9, 2023
@eronnen
fix ${relativeFileDirname} in findInFilesCommand when using remote (#…
1b5e85f 
…180554)

fix ${relativeFileDirname} resolving in findInFilesCommand when using remote #180553
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 9, 2023
@roblourens roblourens added the verified Verification succeeded label Jun 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andreamah andreamah

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

fix ${relativeFileDirname} in findInFilesCommand when using remote eronnen/vscode
4 participants
@roblourens @andreamah @eronnen @VSCodeTriageBot