Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ${relativeFileDirname} in findInFilesCommand when using remote #180554

Merged
merged 1 commit into from
May 9, 2023
Merged

fix ${relativeFileDirname} in findInFilesCommand when using remote #180554

merged 1 commit into from
May 9, 2023

Conversation

eronnen
Copy link
Contributor

@eronnen eronnen commented Apr 21, 2023 •
edited
Loading

fixes #180553

@eronnen eronnen changed the title fix file variables resolving in indInFilesCommand when using remote fix file variables resolving in findInFilesCommand when using remote Apr 21, 2023
@eronnen eronnen changed the title fix file variables resolving in findInFilesCommand when using remote fix file variables resolving in findInFilesCommand when using remote Apr 21, 2023
@eronnen eronnen force-pushed the fix-search-variable-resolving-in-remote branch from 98944fc to e5161f6 Compare April 21, 2023 17:46
@eronnen eronnen changed the title fix file variables resolving in findInFilesCommand when using remote fix ${relativeFileDirname} in findInFilesCommand when using remote Apr 21, 2023
@eronnen eronnen force-pushed the fix-search-variable-resolving-in-remote branch from e5161f6 to e4f5791 Compare April 21, 2023 18:00
andreamah
andreamah approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix! 👌

@andreamah andreamah merged commit 1b5e85f into microsoft:main May 9, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

@bhavyaus bhavyaus bhavyaus approved these changes

@andreamah andreamah andreamah approved these changes

Assignees

@andreamah andreamah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

relativeFileDirname not resolved in search command in WSL/SSH
4 participants
@eronnen @rzhao271 @bhavyaus @andreamah