Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dynamic extension recommendations #18147

Closed
3 tasks done
joaomoreno opened this issue Jan 5, 2017 · 4 comments
Closed
3 tasks done

Improve dynamic extension recommendations #18147

joaomoreno opened this issue Jan 5, 2017 · 4 comments
Assignees
@waderyan
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming
Milestone
January 2017

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jan 5, 2017 •
edited
Loading

  • Include the language ID in the query
    • We might need to curate a mapping
  • Add extensions tips to the results of "find extensions for this file type"
@joaomoreno joaomoreno added extensions Issues concerning extensions feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming labels Jan 5, 2017
@joaomoreno joaomoreno added this to the January 2017 milestone Jan 5, 2017
@egamma egamma mentioned this issue Jan 5, 2017
Closed
56 tasks
joaomoreno added a commit that referenced this issue Jan 23, 2017
@joaomoreno
add extra keywords to language extension query
1285d40 
related to #18147
joaomoreno added a commit that referenced this issue Jan 23, 2017
@joaomoreno
add ext recommendations to file extension query
e91b526 
related to #18147
joaomoreno added a commit that referenced this issue Jan 23, 2017
@joaomoreno
augment extension query based on mode name
2e3b591 
related to #18147
@joaomoreno
Copy link
Member Author

@waderyan

I've pushed a couple of changes:

  • Querying for file extensions will now include a further set of keywords to search for. These keywords come from:
    • The language mode's name, in case we actually know about that file extension
    • A curated map of keywords, which needs population. I'll leave that to you 👍
  • Additionally, the results will be merged with any recommendations we might have for that file extension

@joaomoreno joaomoreno mentioned this issue Jan 23, 2017
Closed
2 tasks
@waderyan
Copy link

FYI - done on my end.

@waderyan
Copy link

Ah nevermind and please ignore #19102. I see that I need to fill in the map (I thought you meant for the tips section... which is done :) )

@waderyan waderyan reopened this Jan 24, 2017
@waderyan
Copy link

PR here - https://github.com/Microsoft/vscode-distro/pull/74

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@waderyan waderyan

Labels
extensions Issues concerning extensions feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
2 participants
@joaomoreno @waderyan