-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable COI for desktop with credentialless
#186614
Comments
…e flag from "enable-coi" to "disable-coi" fixes #186614
Reverted, reopened because this has very likely caused #187030 |
Enabling COI caused a perf regression (#187030) and therefore we are holding back. @deepak1556 Any idea why enabling COI would cause this? |
Looked into this today and I have an answer for the slowdown, In all cases, the first navigation to an origin happens from BrowserInstance Swap result with COI disabled: Process list result with COI disabled: When coi is enabled on an origin, chromium has logic (added in https://chromium-review.googlesource.com/c/chromium/src/+/3945190) to always force swap the browserinstance which leads to creation of new render process. This seems to apply to even when navigating from the BrowserInstance Swap result with COI enabled: Process list result with COI enabled: RenderFrameHostImpl::DidCommitProvisionalLoad for COI enabled It looks like the site instances now have a new lock attribute called tl:dr; there is a restart of the render process when coi is enabled and this is a penalty we will have to pay with coi origins for the initial navigation. Maybe chromium can adjust if first navigation on the app launch is to a coi origin then the process lock on null origin can be retagged and reused ? This needs discussion in upstream. |
For desktop we can enable COI with
COEP: credentialless
. That's possible because chromium supports this new/proposed header value which relaxed loading cross-origin resources lacking the CORP header.The text was updated successfully, but these errors were encountered: