Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Always publish build artifacts despite test failures #187122

Closed
joaomoreno opened this issue Jul 6, 2023 · 0 comments · Fixed by #187134
Closed

Build: Always publish build artifacts despite test failures #187122

joaomoreno opened this issue Jul 6, 2023 · 0 comments · Fixed by #187134
Assignees
@joaomoreno
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Milestone
July 2023

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jul 6, 2023 •
edited
Loading

Right now, if a product build fails on tests, no build artifacts get published.
@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Jul 6, 2023
@joaomoreno joaomoreno added this to the July 2023 milestone Jul 6, 2023
@joaomoreno joaomoreno self-assigned this Jul 6, 2023
@joaomoreno joaomoreno mentioned this issue Jul 6, 2023
Merged
joaomoreno added a commit that referenced this issue Jul 6, 2023
@joaomoreno
always publish build artifacts, if built
56a2ceb 
fixes #187122
joaomoreno added a commit that referenced this issue Jul 7, 2023
@joaomoreno
Always publish build artifacts, if built (#187134)
0917209 
* always publish build artifacts, if built

fixes #187122

* fix windows build

* fix builds

* fix

* more fixes

* further debug

* fix yarn

* remove debug

* remove 7zip dependency

* fix snap
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Always publish build artifacts, if built microsoft/vscode
2 participants
@joaomoreno @VSCodeTriageBot