Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToC shows up while doing search while workbench.settings.settingsSearchTocBehavior set to hide #194812

Closed
rzhao271 opened this issue Oct 4, 2023 · 0 comments · Fixed by #194821
Closed

ToC shows up while doing search while workbench.settings.settingsSearchTocBehavior set to hide #194812

rzhao271 opened this issue Oct 4, 2023 · 0 comments · Fixed by #194821
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
October 2023

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Oct 4, 2023 •
edited

  1. On any OS on the latest Stable or Insiders, navigate to the Settings editor
  2. Set workbench.settings.settingsSearchTocBehavior to hide
  3. Clear the search query
  4. Search for a setting
  5. 🐛 The ToC still shows up

This issue started occurring after the Settings editor switched to using a split view to allow for a resizable table of contents. For reference, in v1.63.2, searching for a setting while workbench.settings.settingsSearchTocBehavior was set to hide would hide the ToC, and clearing out the search query would show the ToC again.
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken settings-editor VS Code settings editor issues labels Oct 4, 2023
@rzhao271 rzhao271 added this to the October 2023 milestone Oct 4, 2023
@rzhao271 rzhao271 self-assigned this Oct 4, 2023
@rzhao271 rzhao271 mentioned this issue Oct 4, 2023
Merged
rzhao271 added a commit that referenced this issue Oct 4, 2023
@rzhao271
Hide ToC during search if requested
30b9a9a 
Fixes #194812
rzhao271 added a commit that referenced this issue Oct 10, 2023
@rzhao271
Hide ToC during search if requested (#194821)
b63441d 
Fixes #194812
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 10, 2023
@alexr00 alexr00 added the verified Verification succeeded label Oct 26, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@rzhao271 @Alex0007
Hide ToC during search if requested (microsoft#194821)
3ba0335 
Fixes microsoft#194812
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
October 2023
Development

Successfully merging a pull request may close this issue.

Hide ToC during search if requested microsoft/vscode
3 participants
@rzhao271 @alexr00 @VSCodeTriageBot