Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Surround with snippet" command is gone #204506

Closed
josephgarnier opened this issue Feb 6, 2024 · 6 comments
Closed

"Surround with snippet" command is gone #204506

josephgarnier opened this issue Feb 6, 2024 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken snippets verified Verification succeeded

Comments

@josephgarnier
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.86.0
  • OS Version: Linux Mint 21.3 and Windows 10

Steps to Reproduce:

  1. Launch VS Code without extension : code --disable-extensions.
  2. Create a new file (with markdown extension, for example).
  3. Write a word and highlights it.
  4. In Command Palette, try to find Surround With Snippet :( (more details in VS Code documentation).

This bug appeared with the January update and was found on 3 different computers (2 on Windows, 1 on Linux).

@josephgarnier josephgarnier changed the title "Surround with snippet" is gone "Surround with snippet" command is gone Feb 6, 2024
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug snippets regression Something that used to work is now broken labels Feb 6, 2024
@jrieken
Copy link
Member

jrieken commented Feb 6, 2024

@josephgarnier good catch, this regressed with 29a6631 (fyi @justschen)

There is a workaround because the action is still there but got renamed confusingly. It's new name is "More..."

@justschen
Copy link
Contributor

justschen commented Feb 6, 2024

ah good catch. will address this missing in command palette in recovery 2 potentially.

with the naming, I think we discussed having it as More... as opposed to having the full Surround with Snippet...

however, I understand it can be confusing. maybe having it be Snippet... instead?

edit: yep, seems like its just a naming convention change. After highlighting some text and going to command palette, Snippets: More... is the new name in the command palette.

@jrieken
Copy link
Member

jrieken commented Feb 7, 2024

with the naming, I think we discussed having it as More... as opposed to having the full Surround with Snippet...

Using "More..." in the code actions menu makes sense, but for the command palette the full name "Surround with Snippet..." should be shown

@jrieken jrieken added the candidate Issue identified as probable candidate for fixing in the next release label Feb 7, 2024
@aiday-mar
Copy link
Contributor

aiday-mar commented Feb 7, 2024

Issue is temporarily assigned to the recovery 2 milestone. If it is not merged during recovery because no other candidates appear, milestone should be changed to February 2024.

@jrieken
Copy link
Member

jrieken commented Feb 7, 2024

also #204587 fixes this for next insiders

@aiday-mar
Copy link
Contributor

Issue is closed because fix has been merged into release and main

@aiday-mar aiday-mar added the verified Verification succeeded label Feb 14, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken snippets verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants