Productise or remove explorer experimental custom hover

[bpasero]

vscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts

Lines 402 to 420 in b2598b9

	renderTemplate(container: HTMLElement): IFileTemplateData {
	const templateDisposables = new DisposableStore();
	const experimentalHover = this.configurationService.getValue<boolean>('explorer.experimental.hover');
	const label = templateDisposables.add(this.labels.create(container, { supportHighlights: true, hoverDelegate: experimentalHover ? this.hoverDelegate : undefined }));
	templateDisposables.add(label.onDidRender(() => {
	try {
	if (templateData.currentContext) {
	this.updateWidth(templateData.currentContext);
	}
	} catch (e) {
	// noop since the element might no longer be in the tree, no update of width necessary
	}
	}));
	const contribs = explorerFileContribRegistry.create(this.instantiationService, container, templateDisposables);
	const templateData: IFileTemplateData = { templateDisposables, elementDisposables: templateDisposables.add(new DisposableStore()), label, container, contribs };
	return templateData;
	}

[benibenj]

I'll make sure to adapt this when I finish the hover work for lists

[bpasero]

@lramos15 is the idea of the setting to be able to disable the hover in the explorer (#173236)? Why did it never become a normal option then but experimental?

[lramos15]

Redmond agreed that disabling the hover completely was a bad idea since it would open the door up for people requesting settings for disabling the hover in many different places. Instead we aimed to solve the main problem I heard about the explorer hover which is that it does not include useful information and can actually obstruct the information the explorer displays. For this, we aimed to try to implement a hover similar to what windows does but it ended up causing too many regressions

[bpasero]

@lramos15 but people that are annoyed by the hover can configure a high hover delay (I actually do that) and then this should be OK no?

[lramos15]

That messes with all workbench hovers though

[benibenj]

@lramos15 do we have users using the experimental custom hover? I also gave it a try to have it similar to the windows explorer but it is not possible to do this well. So personally I think we can remove the experimental explorer hover.

[benibenj]

Regarding #173236: I agree with @lramos15. Changing the hover delay should not be the solution as it affects all hovers in the workbench. Also adding a setting for disabling the hover in the explorer might have the danger of users wanting to support it in all other places individually which would not be great, but we still need to find a better solution here so having a setting for just the explorer might have to be a solution. Another option could be to show the hover to the side of the element making sure it does not cover any other elements

[lramos15]

@benibenj I think we can just remove the explorer hover code. It is very broken and not something we support, regardless of the users. I don't know anyone who is using it as I have not heard any discussion about it for quite some time.

[bpasero]

Then lets do that.