Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover for annotated explorer entry shows up in wrong spot #212582

Closed
bpasero opened this issue May 13, 2024 · 9 comments
Closed

Hover for annotated explorer entry shows up in wrong spot #212582

bpasero opened this issue May 13, 2024 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues list-widget List widget issues verified Verification succeeded workbench-hover Hover issues in the workbench
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 13, 2024

image

I did rename a file that was under git control.

@benibenj
Copy link
Contributor

Can't repro. Can you consistently?

@benibenj benibenj added workbench-hover Hover issues in the workbench list-widget List widget issues file-explorer Explorer widget issues bug Issue identified by VS Code Team member as probable bug labels May 13, 2024
@bpasero
Copy link
Member Author

bpasero commented May 13, 2024

Btw I had the timeline view also opened, expanded, not sure if it matters.

@benibenj benibenj added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label May 15, 2024
@vscodenpa
Copy link

We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our issue reporting guidelines might help you with that.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
@bpasero bpasero reopened this May 15, 2024
@bpasero
Copy link
Member Author

bpasero commented May 15, 2024

Sorry, but this still reproduces for me, is there something I can add as logs?

@benibenj
Copy link
Contributor

Ideally I would need exact steps starting from a clean repository up to seeing the bug. It's very hard to tell how this problem could be caused.

@bpasero bpasero removed the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label May 15, 2024
@bpasero bpasero self-assigned this May 15, 2024
@bpasero bpasero added this to the May 2024 milestone May 15, 2024
@bpasero
Copy link
Member Author

bpasero commented May 15, 2024

@benibenj reproduces for me running out of sources:

  • on macOS
  • have a fresh user data dir
  • use settings as in [1]
  • open a folder that is under git control
  • hover over the explorer item

Recording 2024-05-15 at 15 27 31

[1] settings:

{
  // Editor
  "editor.fontFamily": "Fira Code",
  "editor.fontLigatures": true,
  "editor.folding": true,
  "editor.smoothScrolling": false,
  "editor.formatOnPaste": true,
  "editor.mouseWheelScrollSensitivity": 2,
  "[json]": {
    "editor.formatOnSave": false,
    "editor.formatOnPaste": true
  },
  // Workbench
  "workbench.colorCustomizations": {
    // "focusBorder": "#F3F3F3",
    // "inputOption.activeBackground": "#007acc1f",
    // "inputOption.activeBorder": "#007acc1f",
    // "editorLineNumber.activeForeground": "#2b91af",
    // "list.focusHighlightForeground": "#fff",
    // "activityBar.activeBorder": "#2c2c2c",
    // "sideBarSectionHeader.border": "#0000",
    // "list.activeSelectionBackground": "#3399FF",
    // "list.highlightForeground": "#0066BF",
    // "list.activeSelectionIconForeground": "#fff",
    // "contrastActiveBorder": "#ff0000",
    // "focusBorder": "#ff0000"
  },
  "explorer.experimental.hover": true,
  // Terminal
  "terminal.integrated.fontFamily": "Menlo",
  "terminal.integrated.fontSize": 13,
  "terminal.integrated.lineHeight": 1.4,
  // Misc
  "git.confirmSync": false,
  "git.showActionButton": {
    "commit": false,
    "publish": false,
    "sync": false
  },
  "extensions.autoUpdate": true,
  "git.enableSmartCommit": true,
  "problems.decorations.enabled": true,
  "explorer.decorations.colors": false,
  "explorer.confirmDragAndDrop": false,
  "git.autofetch": true,
  "extensions.ignoreRecommendations": true,
  "editor.find.globalFindClipboard": false,
  "git.showInlineOpenFileAction": false,
  "git.ignoreLimitWarning": true,
  "typescript.updateImportsOnFileMove.enabled": "always",
  "git.inputValidationSubjectLength": 500,
  "workbench.tree.renderIndentGuides": "none",
  "editor.renderWhitespace": "none",
  "gulp.autoDetect": "off",
  "scm.defaultViewMode": "list",
  "terminal.integrated.windowsEnableConpty": false,
  "javascript.updateImportsOnFileMove.enabled": "never",
  "debug.onTaskErrors": "debugAnyway",
  "explorer.confirmDelete": false,
  "terminal.integrated.enablePersistentSessions": false,
  "notebook.dragAndDropEnabled": false,
  "editor.bracketPairColorization.enabled": true,
  "window.restoreFullscreen": true,
  "typescript.implementationsCodeLens.enabled": true,
  "debug.internalConsoleOptions": "neverOpen",
  "git.closeDiffOnOperation": true,
  "editor.formatOnSave": true,
  "editor.guides.indentation": false,
  "[powershell]": {
    "files.encoding": "cp437",
    "editor.wordWrap": "on"
  },
  "git.timeline.showUncommitted": true,
  "[hlsl]": {
    "files.encoding": "cp850"
  },
  "security.workspace.trust.untrustedFiles": "open",
  "terminal.integrated.shellIntegration.enabled": true,
  "window.newWindowDimensions": "inherit",
  "editor.fontSize": 13,
  "diffEditor.renderIndicators": false,
  "editor.codeLens": false,
  "git.postCommitCommand": "push",
  "editor.inlayHints.enabled": "off",
  "git.mergeEditor": true,
  "files.defaultLanguage": "html",
  "diffEditor.codeLens": true,
  "workbench.editor.splitInGroupLayout": "vertical",
  "editor.gotoLocation.multipleDefinitions": "goto",
  "editor.scrollbar.vertical": "visible",
  "editor.scrollbar.horizontal": "visible",
  "notebook.formatOnSave.enabled": true,
  "git.openRepositoryInParentFolders": "never",
  "security.allowedUNCHosts": [
    "foo"
  ],
  "workbench.editor.highlightModifiedTabs": true,
  "files.enableTrash": false,
  "terminal.integrated.splitCwd": "workspaceRoot",
  "workbench.editorAssociations": {
    "C:\\foo": "bar"
  },
  "editor.inlineSuggest.enabled": true,
  "diffEditor.experimental.useVersion2": false,
  "telemetry.telemetryLevel": "off",
  "editor.experimental.asyncTokenization": true,
  "files.associations": {
    "*.yaml": "azure-pipelines"
  },
  "window.logFullScreenTransitions": true,
  "workbench.editor.doubleClickTabToToggleEditorGroupSizes": "maximize",
  "window.systemColorTheme": "auto",
  "window.zoomLevel": 1,
  "breadcrumbs.enabled": false,
  "workbench.quickOpen.closeOnFocusLost": false,
  "editor.minimap.enabled": false,
  "typescript.tsserver.log": "verbose",
  "liveServer.settings.donotShowInfoMsg": true,
  "workbench.editor.moveToActiveGroupIfOpen": true,
  "workbench.editor.label.patterns": {
    "**/*.ts": "${dirname(2)} ${filename}"
  },
  "terminal.integrated.experimentalInlineChat": true,
  "accessibility.signals.voiceRecordingStopped": {
    "sound": "on"
  },
  "scm.workingSets.enabled": true,
  "workbench.editor.enablePreview": false,
  "scm.workingSets.default": "empty",
  "github.copilot.advanced": {
    "debug.overrideChatEngine": "gpt-4",
    "debug.overrideChatMaxTokenNum": 8192,
    "useCAPI": true,
    "debug.reportFeedback": true,
    "renameSuggestionsEnabled": true,
    "debug.useElectronFetcher": true
  },
  "github.copilot.chat.welcomeMessage": "never",
  "typescript.tsserver.experimental.useVsCodeWatcher": true,
  "window.customTitleBarVisibility": "windowed",
  "security.promptForLocalFileProtocolHandling": false,
  "workbench.startupEditor": "none",
  "search.exclude": {
    "/Users/bpasero/Documents/ticino-playground/lib/**": true
  },
  "workbench.localHistory.mergeWindow": 1,
  "notebook.experimental.cellChat": true,
  "notebook.experimental.generate": true,
  "workbench.editor.alwaysShowEditorActions": true,
  "editor.accessibilitySupport": "off",
}

@benibenj
Copy link
Contributor

I think it's being caused by "explorer.experimental.hover": true. Can you remove it and see if it is still the case? If so, we can close this issue as the plan is to remove that setting.

@bpasero
Copy link
Member Author

bpasero commented May 16, 2024

@benibenj yes you are right! I forgot that I had configured it, why are we still carrying around an extra custom hover for the explorer?

@benibenj
Copy link
Contributor

I thought it was going to be removed but I can do it now #205061

@bpasero bpasero added the verified Verification succeeded label May 24, 2024
@bpasero bpasero removed their assignment May 24, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues list-widget List widget issues verified Verification succeeded workbench-hover Hover issues in the workbench
Projects
None yet
Development

No branches or pull requests

3 participants