Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accidental dedent for in and when dedent in Ruby comments #206292

Closed
rebornix opened this issue Feb 26, 2024 · 2 comments
Closed

Accidental dedent for in and when dedent in Ruby comments #206292

rebornix opened this issue Feb 26, 2024 · 2 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
February 2024

Comments

@rebornix
Copy link
Member

Originally from vinistock

I was testing the changes from #205397 in Insiders and I noticed that the code was incorrectly being dedented when typing in or when in comments.
@rebornix rebornix added the candidate Issue identified as probable candidate for fixing in the next release label Feb 26, 2024
@rebornix rebornix added this to the February 2024 milestone Feb 26, 2024
@rebornix
Copy link
Member Author

This was originally introduced in #205397 and @vinistock already has a fix via #206132. However since the fix is late, we may want to revert the indentation rules change for stable release.

rebornix added a commit that referenced this issue Feb 26, 2024
@rebornix
Fix #206292. Revert ruby decrease indent rule.
1a1888d
rebornix added a commit that referenced this issue Feb 26, 2024
@rebornix
Fix #206292. Revert ruby decrease indent rule. (#206295)
927ae34
@rzhao271
Copy link
Contributor

\closedWith 927ae34

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 27, 2024
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Feb 27, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
February 2024
Development

No branches or pull requests
3 participants
@rebornix @rzhao271 @VSCodeTriageBot