Fix accidental dedent for in
and when
dedent in Ruby comments
#206132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing the changes from #205397 in Insiders and I noticed that the code was incorrectly being dedented when typing
in
orwhen
in comments.We got the parenthesis balance incorrect in the regex. The regex has three outer groups for an or condition and we closed the group incorrectly, which made the last part of the regex skip the
\s*
part (which verifies that only blank spaces are in the front of the string).This PR fixes the bug by properly balancing the parenthesis. The tests was also missing the
^
anchor, which I added to match the language configuration.cc @rebornix