Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"when" support when registering a chat participant #212447

Closed
isidorn opened this issue May 10, 2024 · 1 comment · Fixed by #213425
Closed

"when" support when registering a chat participant #212447

isidorn opened this issue May 10, 2024 · 1 comment · Fixed by #213425
Assignees
@roblourens
Labels
api chat feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2024

Comments

@isidorn
Copy link
Contributor

isidorn commented May 10, 2024

User ask from #199908 (comment)

fyi @amitjoshi438
@roblourens roblourens added feature-request Request for new features or functionality api chat labels May 10, 2024
@roblourens roblourens added this to the May 2024 milestone May 10, 2024
roblourens added a commit that referenced this issue May 24, 2024
@roblourens
Add "when" clause to chat participants
c1cf5af 
Fix #212447
@roblourens roblourens mentioned this issue May 24, 2024
Merged
roblourens added a commit that referenced this issue May 24, 2024
@roblourens
Add "when" clause to chat participants (#213425)
4f03e92 
* Add "when" clause to chat participants
Fix #212447

* Change _agents to a Map and write some tests

* Fix import
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 24, 2024
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this issue May 26, 2024
@roblourens @andremmsilva
Add "when" clause to chat participants (microsoft#213425)
d06268f 
* Add "when" clause to chat participants
Fix microsoft#212447

* Change _agents to a Map and write some tests

* Fix import
@roblourens roblourens mentioned this issue May 26, 2024
Closed
3 tasks
@roblourens roblourens added verification-needed Verification of issue is requested and removed on-testplan labels May 26, 2024
@roblourens
Copy link
Member

roblourens commented May 26, 2024 •
edited
Loading

Steps:

  • Modify https://github.com/microsoft/vscode-extension-samples/tree/main/chat-sample to add a "when" clause to the package.json (requires the chatParticipantAdditions proposal)
  • When the "when" clause evaluates to false, the participant doesn't appear in the suggest widget in the chat input and can't be invoked if you type @name manually.
  • When it's true, the participant can be used normally

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 27, 2024
@jrieken jrieken added the verified Verification succeeded label May 28, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
api chat feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

Add "when" clause to chat participants microsoft/vscode
4 participants
@roblourens @jrieken @isidorn @VSCodeTriageBot