-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure child instantiation service instances are disposed/tracked for disposal #212879
Comments
Best-guess assignment, please re-assign along the way. A sample adoption is d1fdc09
|
jrieken
assigned roblourens, bpasero, jrieken, connor4312 and andreamah and unassigned jrieken
May 16, 2024
jrieken
added a commit
that referenced
this issue
May 16, 2024
bpasero
added a commit
that referenced
this issue
May 18, 2024
TylerLeonhardt
added a commit
that referenced
this issue
May 18, 2024
TylerLeonhardt
added a commit
that referenced
this issue
May 19, 2024
bpasero
added a commit
that referenced
this issue
May 19, 2024
johnyongbeyondsoft
pushed a commit
to johnyongbeyondsoft/vscode
that referenced
this issue
May 20, 2024
johnyongbeyondsoft
pushed a commit
to johnyongbeyondsoft/vscode
that referenced
this issue
May 20, 2024
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this issue
May 22, 2024
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this issue
May 22, 2024
rebornix
added a commit
that referenced
this issue
Jun 4, 2024
sandy081
added a commit
that referenced
this issue
Jun 28, 2024
sandy081
added a commit
that referenced
this issue
Jun 29, 2024
roblourens
added a commit
that referenced
this issue
Jul 1, 2024
roblourens
added a commit
that referenced
this issue
Jul 1, 2024
aaronchucarroll
pushed a commit
to aaronchucarroll/vscode
that referenced
this issue
Jul 10, 2024
* microsoft#212879 dispose child instantiation service * fix tests
aaronchucarroll
pushed a commit
to aaronchucarroll/vscode
that referenced
this issue
Jul 10, 2024
jrieken
added a commit
that referenced
this issue
Jul 12, 2024
Took care of mine last month with #213808 |
jrieken
added a commit
that referenced
this issue
Jul 12, 2024
Tyriar
added a commit
that referenced
this issue
Jul 12, 2024
andreamah
added a commit
that referenced
this issue
Aug 1, 2024
andreamah
added a commit
that referenced
this issue
Aug 1, 2024
BABA983
pushed a commit
to BABA983/vscode
that referenced
this issue
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since recently the instantiation service is disposable. A instantiation service will dispose all service instances it has created and will dispose all its children. In return, children should also be explicitly disposed so that they get released from their parents. This item tracks the adoption of registering child instantiation service instances with a disposable.
* This became an issue because we now prevent GC'ing of child service and thereby implicit clean-up. So, while this is more work/tracking it is true disposing of services. Overall, this isn't severe because the vast majority of insta-children are for scoped context key services
The text was updated successfully, but these errors were encountered: