Register child instantiation service (microsoft#213010)

ref microsoft#212879
johnyongbeyondsoft · May 20, 2024 · f69cac7 · f69cac7
1 parent 86ade0b
commit f69cac7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/vs/workbench/contrib/chat/browser/chatQuick.ts b/src/vs/workbench/contrib/chat/browser/chatQuick.ts
@@ -206,14 +206,15 @@ class QuickChat extends Disposable {
 
 	render(parent: HTMLElement): void {
 		if (this.widget) {
+			// NOTE: if this changes, we need to make sure disposables in this function are tracked differently.
 			throw new Error('Cannot render quick chat twice');
 		}
-		const scopedInstantiationService = this.instantiationService.createChild(
+		const scopedInstantiationService = this._register(this.instantiationService.createChild(
 			new ServiceCollection([
 				IContextKeyService,
 				this._register(this.contextKeyService.createScoped(parent))
 			])
-		);
+		));
 		this.widget = this._register(
 			scopedInstantiationService.createInstance(
 				ChatWidget,