Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] Add editor.findMatchForeground #29091

Closed
ashclarke opened this issue Jun 20, 2017 · 10 comments · Fixed by #213497 or #213686
Closed

[themes] Add editor.findMatchForeground #29091

ashclarke opened this issue Jun 20, 2017 · 10 comments · Fixed by #213497 or #213686
Assignees
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@ashclarke
Copy link

ashclarke commented Jun 20, 2017

When using Find & Replace, I like to highlight the current search match differently. This is particularly helpful when refactoring and proof-reading, especially if there are many matches.

I can add a colour customisation for editor.findMatchBackground to achieve this. However, as the foreground colour is not editable, I have a contrast issue with the default foreground colour in the theme.

In my case, I'd prefer to set the background colour to something light, like #b2b231 and change the foreground colour of the match to #000000.

Obviously not a pressing issue; a nice to have 👍

@aeschli aeschli changed the title Theming Suggestion - Add editor.findMatchForeground [themes] Add editor.findMatchForeground Jun 21, 2017
@aeschli aeschli added feature-request Request for new features or functionality themes Color theme issues labels Jun 21, 2017
@aeschli aeschli added this to the Backlog milestone Jun 21, 2017
@jacobcassidy
Copy link

Any progress on this issue? Support for TextMate's "findHighlightForeground" would solve this too. I'm unable to use the "editor.findMatchBackground" as intended because there's currently no way to change the foreground. Which means when the foreground of the text happens to be the same as the background, it disappears into the block.

See screenshots below for clarity....

First is VSC where the element's foreground text happens to be the same color as the "editor.findMatchBackground" color:

vsc-match

Then we have SublimeText using findHighlightForeground to set the foreground for the focused match:

sublime-match

@matthias-ccri
Copy link

image
😭

@lqzhgood
Copy link

lqzhgood commented Jul 21, 2019

I think all font state Foreground colors should be supported.
Like wordHighlight selectionHighlight ....

Because color and background are usually paired.

@thisVioletHydra
Copy link

thisVioletHydra commented May 26, 2020

image
pls add Foreground!

@TarasIvaschuk
Copy link

pls add!!!

@radek-jurica
Copy link

So I guess there is no way how to change the findmatchforeground color right?

@Iron27
Copy link

Iron27 commented May 15, 2022

Yes, please add:
editor.findMatchForeground
editor.findMatchHighlightForeground (ideal, but optional as editor.findMatchForeground can likely offer sufficient contrast for both contexts)

Thank you!

@carpii
Copy link

carpii commented May 5, 2024

is editor.findMatchForeground still unsupported, or or is there some theming stuff I should be using instead?

If not please consider implementing it. It seems like a fairly obvious UI setting, but its now 7 years since it was first suggested

Thanks

@hediet hediet modified the milestones: Backlog, May 2024 May 27, 2024
@hediet hediet added the editor-core Editor basic functionality label May 27, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 27, 2024
@benibenj benibenj added the verification-needed Verification of issue is requested label May 27, 2024
@aeschli aeschli assigned hediet and unassigned aeschli May 27, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 28, 2024
@alexr00
Copy link
Member

alexr00 commented May 28, 2024

I might be misunderstanding how this is supposed to work, but if editor.findMatchForeground isn't explicitly set by the theme, then I expect the find matches to keep their syntax highlighting colors, like this:

image

However, instead I see that all find matches have the same foreground, even though it isn't set by my theme or by my settings:

image

This can look more dramatic with my usual theme:

image

@alexr00 alexr00 reopened this May 28, 2024
@alexr00 alexr00 added the verification-found Issue verification failed label May 28, 2024
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label May 28, 2024
@SimonSiefke
Copy link
Contributor

@alexr00 That's a bug, thanks for finding! PR #213686 should fix it!

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 30, 2024
@benibenj benibenj added the verified Verification succeeded label May 30, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet