Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update find match to be rose #58

Closed
mvllow opened this issue Apr 30, 2022 · 0 comments · Fixed by #101
Closed

Update find match to be rose #58

mvllow opened this issue Apr 30, 2022 · 0 comments · Fixed by #101
Labels
upstream

Comments

@mvllow
Copy link
Member

mvllow commented Apr 30, 2022 •
edited
Loading

Waiting on microsoft/vscode#29091
@mvllow mvllow mentioned this issue May 11, 2022
Closed
fvrests added a commit that referenced this issue Oct 8, 2024
@fvrests
feat: use gold for find match results
55b3b9c 
Closes #58 - VSCode added editor.findMatchForeground upstream, enabling better customization of find match colors. Used gold instead of rose for search matches as rose is already used throughout UI. This is an opinionated change; open to feedback.
@fvrests fvrests mentioned this issue Oct 8, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use gold for find match results rose-pine/vscode
1 participant
@mvllow