Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline diff line numbers broken after reload #223410

Closed
mjbvz opened this issue Jul 23, 2024 · 0 comments · Fixed by #223498
Closed

Inline diff line numbers broken after reload #223410

mjbvz opened this issue Jul 23, 2024 · 0 comments · Fixed by #223498
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2024

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 23, 2024 •
edited

Type: Bug

  1. In a git repo
  2. Make a small change in a tracked file
  3. Open diff from changes scm view
  4. Make sure inline diff is on
  5. Reload window so that diff editor is also reloaded

bug
The wrong line numbers are shown. Notice how many lines 1 there are on the left gutter

Image

VS Code version: Code - Insiders 1.92.0-insider (Universal) (22e3447, 2024-07-23T05:03:52.385Z)
OS version: Darwin arm64 23.5.0
Modes:

System Info
Item Value
CPUs Apple M2 Max (12 x 2400)
GPU Status 2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: disabled_software
video_encode: disabled_software
webgl: unavailable_software
webgl2: unavailable_software
webgpu: unavailable_software
webnn: disabled_off
Load (avg) 10, 6, 5
Memory (System) 64.00GB (1.61GB free)
Process Argv --crash-reporter-id 0fffb5da-9cd7-46fd-9e7f-a1564e8c5fda
Screen Reader no
VM 0%
@hediet hediet added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority diff-editor Diff editor issues labels Jul 24, 2024
@hediet hediet added this to the July 2024 milestone Jul 24, 2024
hediet added a commit that referenced this issue Jul 24, 2024
@hediet
Fixes #223410. Re-layouts the diff editor when decorationsLeft chan…
368c729 
…ges.
@hediet hediet mentioned this issue Jul 24, 2024
Merged
hediet added a commit that referenced this issue Jul 24, 2024
@hediet
Fixes #223410. Re-layouts the diff editor when decorationsLeft chan…
9dc000f 
…ges.
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 24, 2024
@mjbvz mjbvz added the verified Verification succeeded label Jul 24, 2024
nagi1999a pushed a commit to nagi1999a/vscode that referenced this issue Jul 26, 2024
@hediet
Fixes microsoft#223410. Re-layouts the diff editor when `decorationsL…
9f46b6f 
…eft` changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

Fixes #223410. Re-layouts the diff editor when decorationsLeft changes. microsoft/vscode
3 participants
@hediet @mjbvz @VSCodeTriageBot