Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When hovering over vertical menu tooltips, icons have shortcuts in them, but wrapper buttons don't #28695

Closed
TomasHubelbauer opened this issue Jun 14, 2017 · 1 comment · Fixed by #28783
Closed

When hovering over vertical menu tooltips, icons have shortcuts in them, but wrapper buttons don't #28695

TomasHubelbauer opened this issue Jun 14, 2017 · 1 comment · Fixed by #28783
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Milestone
June 2017

Comments

@TomasHubelbauer
Copy link
Contributor

  • VSCode Version: 1.13.0
  • OS Version: Windows 10 Home 10.0.15063

Steps to Reproduce:

  1. Hover over vertical menu icons and slowly slide up and down
  2. See the tooltip containing shortcut where directly over icon, not when just over the button space

Should be consistent across both

vs-code-tooltips
@ramya-rao-a
Copy link
Contributor

Nice catch!

@bpasero bpasero added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Jun 14, 2017
@bpasero bpasero added this to the Backlog milestone Jun 14, 2017
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jun 14, 2017
@ramya-rao-a ramya-rao-a assigned bpasero and unassigned bpasero Jun 14, 2017
@brandedoutcast brandedoutcast mentioned this issue Jun 15, 2017
Merged
@bpasero bpasero modified the milestones: July 2017, Backlog, June 2017 Jun 16, 2017
bpasero pushed a commit that referenced this issue Jun 16, 2017
@rohithkumbharkar @bpasero
Fixes issue #28695 with tooltips in Activity Bar (#28783)
5059f47
@jrieken jrieken added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

Successfully merging a pull request may close this issue.

Fixes issue #28695 with tooltips in Activity Bar
4 participants
@bpasero @jrieken @TomasHubelbauer @ramya-rao-a