Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby syntax highlighter fails when parameter defaults contain a nested Hash #31738

Closed
nelseric opened this issue Jul 31, 2017 · 1 comment
Closed

Ruby syntax highlighter fails when parameter defaults contain a nested Hash #31738

nelseric opened this issue Jul 31, 2017 · 1 comment
Assignees
@rebornix @aeschli

Comments

@nelseric
Copy link

  • VSCode Version: 1.14.2
  • OS Version: Mac OS X 10.11.6

Steps to Reproduce:

  1. Create a new ruby file with the contents
def complicated_params(options = {
  column_mapping: {
    'account_number' => 'acct_no',
    'mailing_address' => 'mail_addr_line_1',
    'customer_name' => ['customer_name', 'company_name'],
  },
})

  pp options
end

image

Reproduces without extensions: Yes
@aeschli
Copy link
Contributor

aeschli commented Aug 3, 2017

This issue was moved to textmate/ruby.tmbundle#113

@aeschli aeschli closed this as completed Aug 3, 2017
@aeschli aeschli mentioned this issue Aug 3, 2017
Closed
infininight added a commit to textmate/ruby.tmbundle that referenced this issue Aug 5, 2017
@infininight
Match paired parentheses and braces in arguments
905e49f 
Fixes #113 and microsoft/vscode#31738.
noniq added a commit to die-antwort/textmate-bundles that referenced this issue Aug 5, 2017
@noniq
Submodule updates: Cucumber, JavaScript, Ruby
bd94196 
Cucumber.tmbundle: 31ab38f..17a4419

  * f826aa8 Minor updates to README.markdown (Zearin)

    * Changed keyboard shortcuts to use the Unicode symbols seen in menus
    * Capitalize “Step” and “Feature” (as they have a specific meaning in
    this context)
    * Various minor edits for phrasing and grammar

JavaScript.tmbundle: 57fc67c..90c3273

  * fccf0af Require word boundary after class keyword (Michael Sheets)

    Fixes #59.

Ruby.tmbundle: 896ecae..13903e0

  * 905e49f Match paired parentheses and braces in arguments (Michael Sheets)

    Fixes #113 and microsoft/vscode#31738.

  * 0d092b5 Remove obsolete test. (Stefan Daschek)

    Actually, after the previous commit the code in executable.rb does no
    longer use `ENV['TM_BUNDLE_SUPPORT']` at all, so we can simplify the
    test setup and also remove one test case completely.

  * 277473e Fix `Executable.find` with RVM when used from other bundle. (Stefan Daschek)

    If the Ruby bundle is not the primary bundle but used from another
    bundle (by declaring a dependency), `$TM_BUNDLE_SUPPORT_PATH` will point
    to that bundle’s support directory. This lead to a wrong path being
    generated for the `rvw_wrapper` script in these cases. See
    rspec/rspec.tmbundle#108 for an example.
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nelseric @rebornix @aeschli @chrmarti