Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.17.0 Integrated Terminal Chinese Problem #35660

Closed
Yurunsoft opened this issue Oct 6, 2017 · 9 comments
Closed

1.17.0 Integrated Terminal Chinese Problem #35660

Yurunsoft opened this issue Oct 6, 2017 · 9 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues verified Verification succeeded
Milestone
September Recover...

Comments

@Yurunsoft
Copy link

  • VSCode Version: Code 1.17.0 (be377c0, 2017-10-04T23:45:46.804Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
php-intellisense fel 1.5.1
crane Hvy 0.3.8
php-docblocker nei 1.3.0

Steps to Reproduce:

image

image

image

Reproduces without extensions: Yes/No
@vscodebot vscodebot bot added the new release label Oct 6, 2017
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Oct 6, 2017
@Yurunsoft
Copy link
Author

gif

@mysticatea
Copy link

This happens in Japanese as well. It seems a problem of dirty checking.

terminal-problem

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Oct 6, 2017
@Tyriar Tyriar added this to the September Recovery 2017 milestone Oct 6, 2017
This was referenced Oct 6, 2017
Closed
Closed
Closed
Tyriar added a commit that referenced this issue Oct 6, 2017
@Tyriar
Fix terminal rendering and link issues
cd8c8dd 
Pulls in xtermjs/xterm.js#1038 and xtermjs/xterm.js#1026

Fixes #35662
Fixes #35188
Fixes #35660
Fixes #35649
@Tyriar Tyriar closed this as completed Oct 6, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 6, 2017

Pushed to release/1.17 & master

Tyriar added a commit that referenced this issue Oct 6, 2017
@Tyriar
Fix rendering issues in terminal
c7d4aed 
Fixes #35188
Fixes #35660
Fixes #35660
@mysticatea
Copy link

Thank you!

@orzFly orzFly mentioned this issue Oct 6, 2017
Closed
@ghost ghost mentioned this issue Oct 6, 2017
Closed
This was referenced Oct 6, 2017
Closed
Closed
Closed
@meowao meowao mentioned this issue Oct 6, 2017
Closed
@wevsty wevsty mentioned this issue Oct 7, 2017
Closed
@stone-zeng stone-zeng mentioned this issue Oct 8, 2017
Closed
This was referenced Oct 9, 2017
Closed
Closed
@banyudu banyudu mentioned this issue Oct 9, 2017
Closed
@Dwscdv3 Dwscdv3 mentioned this issue Oct 10, 2017
Closed
@Tyriar Tyriar mentioned this issue Oct 10, 2017
Closed
@Dwscdv3
Copy link

Dwscdv3 commented Oct 10, 2017

@Tyriar It seems the patch isn't part of 1.17 release. Is there a setting to switch back to the old rendering engine?

This was referenced Oct 10, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@chrmarti chrmarti added the verified Verification succeeded label Oct 10, 2017
@Tyriar Tyriar mentioned this issue Oct 10, 2017
Closed
@5idu
Copy link

5idu commented Oct 11, 2017

1.17.1 version is ok.

@wuhuatianbao007
Copy link

good

@Yurunsoft
Copy link
Author

it's good!
666!

@ai0376
Copy link

ai0376 commented Oct 12, 2017

it's good!

sandy081 pushed a commit that referenced this issue Oct 16, 2017
@Tyriar @sandy081
Fix rendering issues in terminal
2c6cd2c 
Fixes #35188
Fixes #35660
Fixes #35660
@Tyriar Tyriar mentioned this issue Oct 28, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
September Recovery 2017
Development

No branches or pull requests
8 participants
@mysticatea @Tyriar @ai0376 @Dwscdv3 @chrmarti @Yurunsoft @wuhuatianbao007 @5idu