Rendering improvements #1038
Merged
Rendering improvements #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
State/diffing code is kept in comments as it may be reinstated soon. Fixes xtermjs#1035 Fixes xtermjs#1036 Fixes xtermjs#1032 Fixes xtermjs#1037
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Oct 6, 2017
Pulls in xtermjs/xterm.js#1038 and xtermjs/xterm.js#1026 Fixes #35662 Fixes #35188 Fixes #35660 Fixes #35649
parisk
approved these changes
Oct 6, 2017
mofux
reviewed
Oct 11, 2017
| @@ -107,4 +107,17 @@ export class ColorManager implements IColorManager { | |||
| this.colors.ansi[14] = theme.brightCyan || DEFAULT_ANSI_COLORS[14]; | |||
| this.colors.ansi[15] = theme.brightWhite || DEFAULT_ANSI_COLORS[15]; | |||
| } | |||
|
|
|||
| private _validateColor(color: string, fallback: string): string { | |||
There was a problem hiding this comment.
Doesn't this mean that theme.background can only be a hex color, not rgb(a) - because otherwise it would just use the fallback color?
There was a problem hiding this comment.
It does for background, validate could be changed to accommodate rgb/rgba/etc. though.
This was needed to be able to do this:
+ const r = parseInt(background.substr(1, 2), 16);
+ const g = parseInt(background.substr(3, 2), 16);
+ const b = parseInt(background.substr(5, 2), 16);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1032
Fixes #1031
Fixes #1035
Fixes #1036
Fixes #1032
Fixes #1037
See individual commits for what was actually done. It turns out drawing the entire line like this is fairly fast, typically ranging from 0.5ms to 4ms on my macbook. The boost in stability/accuracy that this change brings is a must for now. It would be good to go back to intelligently diffing before drawing eventually (when we're certain the characters aren't overlapping).