Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] Search doesn't un-collapse section if also switching files #41419

Closed
ghost opened this issue Jan 10, 2018 · 2 comments
Closed

[folding] Search doesn't un-collapse section if also switching files #41419

ghost opened this issue Jan 10, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@ghost
Copy link

ghost commented Jan 10, 2018

  • VSCode Version: Code - Insiders 1.20.0-insider (2bab83a, 2018-01-10T06:16:46.780Z)
  • OS Version: Linux x64 4.4.0-21-generic
  • Extensions: none
---

Steps to Reproduce:

  1. Create a.ts and write:
function f() {
    searchtext;
}
  1. Collapse the function.
  2. Create b.ts (without closing a.ts).
  3. Ctrl-shift-f, type searchtext, and hit enter. You should see a result in a.ts.
  4. Click on the result and you are navigated to a.ts -- but you can't see searchtext anywhere since f is still collapsed.
  5. It will uncollapse if you click on searchtext a second time while still looking at a.ts.
@vscodebot vscodebot bot added the insiders label Jan 10, 2018
@vscodebot vscodebot bot added the typescript Typescript support issues label Jan 10, 2018
@mjbvz mjbvz added editor-folding Editor code folding issues and removed typescript Typescript support issues labels Jan 11, 2018
@mjbvz mjbvz assigned aeschli and unassigned mjbvz Jan 11, 2018
@aeschli aeschli changed the title Search doesn't un-collapse section if also switching files [folding] Search doesn't un-collapse section if also switching files Jan 11, 2018
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Jan 11, 2018
@aeschli aeschli added this to the January 2018 milestone Jan 11, 2018
@chrmarti chrmarti removed the insiders label Jan 18, 2018
@aeschli aeschli modified the milestones: January 2018, February 2018 Feb 1, 2018
@aeschli aeschli modified the milestones: February 2018, March 2018 Feb 26, 2018
@ghost
Copy link
Author

ghost commented Mar 13, 2018

This problem also affects go-to-definition:
a.ts

namespace N {
    export function f() {}
}

b.ts

N.f();

Collapse a.ts and go-to-definition on f in b.ts -- I would expect it to expand sections as necessary to get me to the definition, but instead I'm just left at the top of the file.

@aeschli aeschli modified the milestones: March 2018, April 2018 Mar 27, 2018
@aeschli aeschli modified the milestones: April 2018, May 2018 Apr 18, 2018
@aeschli aeschli modified the milestones: May 2018, June 2018 May 29, 2018
@aeschli aeschli modified the milestones: June 2018, July 2018 Jun 27, 2018
@aeschli aeschli modified the milestones: July 2018, Backlog Jul 30, 2018
@aeschli aeschli added the *out-of-scope Posted issue is not in scope of VS Code label Oct 9, 2019
@vscodebot vscodebot bot closed this as completed Oct 9, 2019
@aeschli aeschli removed the *out-of-scope Posted issue is not in scope of VS Code label Oct 9, 2019
@aeschli aeschli reopened this Oct 9, 2019
@microsoft microsoft deleted a comment from vscodebot bot Oct 9, 2019
@ewerybody
Copy link

Is this hard to fix?! It's pretty annoying. I collapse a lot :/

@aeschli aeschli modified the milestones: Backlog, October 2020 Oct 14, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@ewerybody @aeschli @rzhao271 @chrmarti @mjbvz and others