Windows update failed: Failed to get process file name

[fparedlo]

• VSCode Version:
• OS Version:

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No
vscode-inno-updater.log

Apr 13 10:02:44.066 INFO Starting: C:\Program Files\Microsoft VS Code\Code.exe, false
Apr 13 10:02:44.067 INFO Checking for running Code.exe processes... (attempt 1)
Apr 13 10:02:44.068 INFO Code.exe is running, wait a bit
Apr 13 10:02:44.568 INFO Checking for running Code.exe processes... (attempt 2)
Apr 13 10:02:44.570 INFO Code.exe is running, wait a bit
Apr 13 10:02:45.070 INFO Checking for running Code.exe processes... (attempt 3)
Apr 13 10:02:45.071 INFO Code.exe is running, wait a bit
Apr 13 10:02:45.571 INFO Checking for running Code.exe processes... (attempt 4)
Apr 13 10:02:45.573 INFO Code.exe is running, wait a bit
Apr 13 10:02:46.073 INFO Checking for running Code.exe processes... (attempt 5)
Apr 13 10:02:46.079 INFO Code.exe is running, wait a bit
Apr 13 10:02:46.579 INFO Checking for running Code.exe processes... (attempt 6)
Apr 13 10:02:46.581 INFO Code.exe is running, wait a bit
Apr 13 10:02:47.081 INFO Checking for running Code.exe processes... (attempt 7)
Apr 13 10:02:47.087 INFO Code.exe is running, wait a bit
Apr 13 10:02:47.587 INFO Checking for running Code.exe processes... (attempt 8)
Apr 13 10:02:47.593 INFO Code.exe is running, wait a bit
Apr 13 10:02:48.093 INFO Checking for running Code.exe processes... (attempt 9)
Apr 13 10:02:48.099 INFO Code.exe is running, wait a bit
Apr 13 10:02:48.599 INFO Checking for running Code.exe processes... (attempt 10)
Apr 13 10:02:48.605 INFO Code.exe is running, wait a bit
Apr 13 10:02:49.105 INFO Checking for running Code.exe processes... (attempt 11)
Apr 13 10:02:49.106 INFO Code.exe is running, wait a bit
Apr 13 10:02:49.606 INFO Checking for running Code.exe processes... (attempt 12)
Apr 13 10:02:49.612 INFO Code.exe is running, wait a bit
Apr 13 10:02:50.113 INFO Checking for running Code.exe processes... (attempt 13)
Apr 13 10:02:50.114 INFO Code.exe is running, wait a bit
Apr 13 10:02:50.614 INFO Checking for running Code.exe processes... (attempt 14)
Apr 13 10:02:50.615 INFO Code.exe is running, wait a bit
Apr 13 10:02:51.115 INFO Checking for running Code.exe processes... (attempt 15)
Apr 13 10:02:51.116 INFO Code.exe is running, wait a bit
Apr 13 10:02:51.616 INFO Checking for running Code.exe processes... (attempt 16)
Apr 13 10:02:51.617 INFO Code.exe is running, wait a bit
Apr 13 10:02:52.117 INFO Checking for running Code.exe processes... (attempt 17)
Apr 13 10:02:52.118 INFO Code.exe is running, wait a bit
Apr 13 10:02:52.618 INFO Checking for running Code.exe processes... (attempt 18)
Apr 13 10:02:52.620 INFO Code.exe is running, wait a bit
Apr 13 10:02:53.120 INFO Checking for running Code.exe processes... (attempt 19)
Apr 13 10:02:53.121 INFO Code.exe is running, wait a bit
Apr 13 10:02:53.621 INFO Checking for running Code.exe processes... (attempt 20)
Apr 13 10:02:53.622 INFO Gave up waiting for Code.exe to exit
Apr 13 10:03:12.895 ERRO Failed to get process file name

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• D (#46214)
• D (#46218)
• D (#46213)
• D (#46219)
• VSCODE (#44313)

[joaomoreno]

Verifier:

I basically don't know what's going on, so the fix here is to improve logging when this happens.

• microsoft/inno-updater@04d4847: I now log the error message from GetModuleFileNameExW
• microsoft/inno-updater@a6bdab2: That previous check was wrong, it was comparing handle with -1, when it should be comparing it with 0. It's very likely that it is OpenProcess which fails, not GetModuleFileNameExW, so...
• ... let's also get the error message from OpenProcess: microsoft/inno-updater@474fa7e
• microsoft/inno-updater@5825fa5 The for loop on running processes was also stopping as soon as one failed, we should attempt to kill all regardless of whether a single one fails.