-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuickPick does not read out placeholder #51824
Comments
(Experimental duplicate detection) |
That sounds like a bug in NVDA to me, but maybe we can tweak the ARIA label for inputs. We could also see if there is a |
@bpasero would you be willing to do some tweaking for this? |
I looked into it and have not good explanation for the behaviour. This seems to be triggered by the fact that the input box has a Our only hope may be to announce the placeholder using We always used the |
@bpasero you can always reach out to this repo here https://github.com/nvaccess/nvda |
This works for me with QuickOpen, but not with QuickInput. Both use |
@chrmarti maybe tree vs list ARIA roles? |
Yes might be. @chrmarti not that I changed one of them to use |
You're right, with your change reverted it no longer works with QuickOpen. |
Not focusing any element in the list lets it read the placeholder. This was supposed to be fixed with #57501 which checks if it is in screen reader mode before setting the focus, but there is a bug that still makes it focus an element in most cases. Will fix. |
Actually should have worked before when screen reader mode was on. Closing as duplicate. |
/duplicate #57501 |
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines. Happy Coding! |
Environment Details:
VSCode Version : 1.24.1
OS Version : Win10
Additional Details:
NVDA 2018.2,JAWS18.0.5038,MAS1.3.1
same issue is observed in JAWS
Repro Steps:
1)Launch VSCode.
2)Navigate to Settings icon in Activity Bar->Press Enter->Select "Color Theme" from dropdown.
3)Check with NVDA reading.
Actual:
NVDA does not read the placeholder present on the screen.
Expected:
NVDA should read the placeholder which is present on the screen.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
[https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
](url)
[User] Impact:
User will not able to know that there is placeholder present on the screen.
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}
Attachment for Reference:
[Accessibility]A11y_VSCode_ColorTheme_Screenreade.pptx
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: