Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support find and filter in breadcrumbs picker #55004

Closed
sandy081 opened this issue Jul 25, 2018 · 6 comments
Closed

Support find and filter in breadcrumbs picker #55004

sandy081 opened this issue Jul 25, 2018 · 6 comments
Assignees
@jrieken
Labels
breadcrumbs feature-request Request for new features or functionality

Comments

@sandy081
Copy link
Member

Testing #54935

  • Open extensionManagement.ts file
  • Open its symbols outline tree from breadcrumbs
  • Type version

Expected to see only the sub tree that has matches. But it shows sibling that does not have matches. For example siblings of IExtensionManifest symbol.

image

Outline view filters them correctly

image
@jrieken
Copy link
Member

jrieken commented Jul 25, 2018

It's 'Find' not 'Filter' - in the outline view the default is also 'Find' but you might have this set to 'Filter'

@jrieken jrieken changed the title Filtering in breadcrumbs also show siblings does not match the filter Support find and filter in breadcrumbs picker Jul 25, 2018
@jrieken jrieken added feature-request Request for new features or functionality breadcrumbs labels Jul 25, 2018
@sandy081
Copy link
Member Author

Right, Its Filter in Outline

@jrieken jrieken mentioned this issue Jul 26, 2018
Closed
@ris58h
Copy link
Contributor

ris58h commented Aug 17, 2018

From my point of view it would be useful to have a toggle button (find/filter) right in the picker's input field. Of course there should be a shortcut for it.

Example:
breadcrumbs-find-toggled
breadcrumbs-filter-toggled

There are such (toggle) buttons in the Search View: Match Case, Match Whole Word, Use Regular Expression.

jrieken added a commit that referenced this issue Aug 23, 2018
@jrieken
extract highlight knowledge as prep to filter, #55004
3663d1f
@jrieken jrieken added this to the August 2018 milestone Aug 23, 2018
jrieken added a commit that referenced this issue Aug 23, 2018
@jrieken
add filtering to breadcrumbs picker, #55004
95e4df2
@jrieken
Copy link
Member

jrieken commented Aug 23, 2018

This is implemented but impacted by #57089

@jrieken jrieken modified the milestones: August 2018, September 2018 Aug 27, 2018
@jrieken
Copy link
Member

jrieken commented Aug 27, 2018

The implementation and tree behaviours aren't good. Removed the option for now and moving this to September.

jrieken added a commit that referenced this issue Aug 27, 2018
@jrieken
don't expose the filter on type option yet, #55004
7a803e5
@jrieken jrieken removed this from the September 2018 milestone Sep 10, 2018
This was referenced Jun 24, 2019
Closed
Merged
@jrieken
Copy link
Member

jrieken commented Jul 25, 2019

this is now like all other trees

@jrieken jrieken closed this as completed Jul 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
breadcrumbs feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ris58h @jrieken @sandy081