Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Breadcrumbs #54935

Closed
2 tasks done
jrieken opened this issue Jul 24, 2018 · 2 comments
Closed
2 tasks done

Test Breadcrumbs #54935

jrieken opened this issue Jul 24, 2018 · 2 comments

Comments

@jrieken
Copy link
Member

jrieken commented Jul 24, 2018

Complexity: 3

re #9418 - This is about breadcrumbs. Please test that

  • you can enable/disable breadcrumbs via a setting
  • you can enable/disable breadcrumbs via the global menu (View > Toggle Breadcrumbs)
  • breadcrumbs show when using tabs or when not using tabs and in both cases an appropriate style is used
  • breadcrumbs show for text files and binary files
  • breadcrumbs show outline symbols when a corresponding extension exists (e.g. JSON, TypeScript etc)
  • breadcrumbs update as you open/close files and, when having outline symbols, as the cursor moves
  • breadcrumbs can be focused via the command palette and via Cmd/Ctrl+Shift+.
  • breadcrumb items can be navigated with Shift+ArrowLeft/Right
  • breadcrumb items can be selected via Shift+Enter or Ctrl/Cmd+Click and the item will be reveal in the editor
  • a picker can shows on Enter or Click
  • the picker moves when pressing Shift+ArrowLeft/Right
  • the picker reveals the current element
  • the picker filters, reveals, and highlights items as you start typing
  • the picker hides when selecting an element, when clicking somewhere else, or when hitting Esc (often enough - that's a known issue)
  • breadcrumbs can be configured how to show the file path and symbol path
  • breadcrumbs can be configured to use quick pick instead of individual pickers
@sandy081
Copy link
Member

@jrieken Good work. It works pretty smooth and nice.

@alexdima
Copy link
Member

Nice job!!!

But I don't understand this row:

  • breadcrumb items can be selected via Shift+Enter or Ctrl/Cmd+Click and the item will be reveal in the editor

Shift+Enter behaves like Escape for me and Cmd+Click behaves like click for me.

@alexdima alexdima removed their assignment Jul 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants