Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.autoWrapping setting can be confused with other wrapping settings #57411

Closed
sandy081 opened this issue Aug 28, 2018 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Testing #57317

The new editor.autoWrapping setting has nothing to do with the wrapping but it auto surrounds selected text. Since it uses word wrapping it can be easily gets confused with other wrapping settings we have.

It is better to rename it. editor.autoSurround as @alexandrudima suggested.

@octref
Copy link
Contributor

octref commented Aug 28, 2018

In the Vim universe this is also called surrond https://github.com/tpope/vim-surround.

@alexdima alexdima added this to the August 2018 milestone Aug 29, 2018
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Aug 29, 2018
@bpasero bpasero added the verified Verification succeeded label Aug 30, 2018
joaomoreno pushed a commit that referenced this issue Sep 13, 2018
…d_branch_name_validation

* Microsoft/master: (4802 commits)
  Fixes #57415: autoSurround - rename "always" to "languageDefined"
  debug: skip over %0
  explorer view: cut down delay time till progress from 3.2s to 1.2s
  file workspace suffix is empty string
  Revert "debug: do not send terminate to EH debugging"
  Fixes #57411: Rename `autoWrapping` to `autoSurround` to avoid confusions related to text wrapping
  Fixes #57453: Avoid thinking the user typed in the find input when setting the search string value
  Synchronisation notification: - Show extension being synchronised - Delete the downloaded extensions
  [html] fix tests
  debug: do not send terminate to EH debugging
  webpack - let build fail when webpack generates an error or a warning
  [html] update service. Fixes #57445
  node-debug@1.27.6
  more complete fix for #57483
  fix #57351
  fix #57483
  fixes #56015
  dispose of RunOnceScheduler properly
  Fixes microsoft/monaco-editor#1021: Use ProviderResult in modes.ts
  fix #55607
  ...
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants