removeFromRecentlyOpened Command Broken

[daytonellwanger]

VSCode Version: 1.27.1-Insiders
OS Version: Win10

Steps to Reproduce:

1. Create an extension that uses the removeFromRecentlyOpened command (e.g. vscode.commands.executeCommand('vscode.removeFromRecentlyOpened', 'somePath'))
2. Run the extension

EXPECTED:
Path is removed from list of recently opened files.

ACTUAL:
Command fails with [UriError]: Scheme contains illegal characters.

The stack shows the error is coming from electron:

Error: [UriError]: Scheme contains illegal characters."
1:"    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:59:35"
2:"    at t.e (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:59:461)"
3:"    at new t (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:60:990)"
4:"    at Function.e.revive (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:60:845)"
5:"    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:353:512"
6:"    at Array.map (<anonymous>)"
7:"    at e.call (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:353:450)"
8:"    at e.onPromise (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:162:803)"
9:"    at e.onRequest (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:163:968)"
10:"    at e.onRawMessage (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:163:885)"

More info:
I've tried passing in strings that have the path formatted in various ways, and am pretty confident they are valid URIs. Additionally, this is a regression. I can run the same extension, use the same argument to the command, on VS Code 1.26.1 (Stable) and have the expected result.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• VSCode won't launch on Windows if path contains # character (#56506)
• Debugging my extension: Cannot find modul '...\out\extension' (#57668)
• Breadcrumbs with new settings editor results in empty window after restart (#54451)
• Error: Promise did not implement oncancel (#55136)
• VS Code not able to start after latest update due to special characters in path (#58042)

[bpasero]

Arguable a candidate if this is a regression.

[sandy081]

file-uri changes went into 1.27

[aeschli]

@daytonellwanger Do you remember what the path was?

[daytonellwanger]

@aeschli looks like you've the issue resolved. Let me know if I can provide further information. I'll verify the fix once it ships.

[daytonellwanger]

I just tested this with today's build
(Version: 1.28.0-insider (system setup)
Commit: 7fcd81c
Date: 2018-09-17T09:37:55.086Z
Electron: 2.0.9
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64)
and am still seeing this issue.
Here's the path I was passing as the argument: C:\Users\daellwan\AppData\Local\Temp\tmp-4CFE9B9A2EED67B43699F7C3340FDD091F7E\Visual Studio Live Share.code-workspace

[daytonellwanger]

Here's how I'm invoking the command and seeing this error:

try {
    await vscode.commands.executeCommand('vscode.removeFromRecentlyOpened', currentWorkspacePath);
} catch (e) {
    debugger;
}

[bpasero]

I see this when running vscode.commands.executeCommand('vscode.removeFromRecentlyOpened', 'C:\\Users\\daellwan\\AppData\\Local\\Temp\\tmp-4CFE9B9A2EED67B43699F7C3340FDD091F7E\\Visual Studio Live Share.code-workspace');
on Windows: