Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 60243 #60607

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Fix 60243 #60607

merged 2 commits into from
Oct 11, 2018

Conversation

chrmarti
Copy link
Contributor

#60243

The problem with the previous fix is that _URI.toJSON() skips empty string properties and URI.isUri() then doesn't recognize it. The fix is to revert to the code from two changes back which also covers #58131.

@aeschli aeschli self-requested a review October 11, 2018 08:24
@chrmarti chrmarti merged commit 56df542 into master Oct 11, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
@alexdima alexdima deleted the chrmarti/60243 branch June 30, 2020 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants