Restarting the debug process fails

[NCC1701M]

Issue Type: Bug

When I'm restart the debugging process of an ASP.Net Core project, in the latest release of VSCode, the debug process will be killed after the build process has started. So the build process fails because the output .dll is still in use and can't be replaced.

Error MSB3027

VS Code version: Code 1.28.0 (431ef9d, 2018-10-05T14:58:53.203Z)
OS version: Windows_NT x64 10.0.15063

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-6440HQ CPU @ 2.60GHz (4 x 2592)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	7.88GB (0.98GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (12)

Extension	Author (truncated)	Version
vscode-svgviewer	css	1.4.7
xml	Dot	2.3.2
tslint	eg2	1.0.40
beautify	Hoo	1.4.4
angular2-switcher	inf	0.1.9
docomment	k--	0.1.2
mssql	ms-	1.4.0
csharp	ms-	1.16.2
vsliveshare	ms-	0.3.788
debugger-for-chrome	msj	4.10.2
createGUID	nwa	0.0.2
sass-indented	rob	1.4.9

[isidorn]

This is a regressoin from our side.
Previously on restart we would first disconnect and only then run the preLaunchTask. Now we would first run the task and only then disconnect.
With the fix, I am bringing back the old proper behavior.
@NCC1701M Can you please try vscode insiders tomorrow and verify this ifxes the issue for you?

Adding candidate to discuss if this fix should be included in the recovery build

[NCC1701M]

@isidorn I'm sorry but I'm not in the office until wednesday. But I can check it then.

[isidorn]

@NCC1701M better late than never, thanks for reporting this!

[joaomoreno]

@isidorn Moving this out to October as discussed.

[isidorn]

fyi @gregg-miskelly and @DustinCampbell in case people hit this and complain in your repository that you are aware of this regression we introduced which is fixed in insiders. In stable it will only be availble when we do our next large release start of november.

[gregg-miskelly]

Thanks! We have gotten reports of this.

[isidorn]

@gregg-miskelly I see it is three users and the issue imho is not critical because if the user starts debugging again all should be good.
It would be great if you just let those users know that they can use vscode insiders as a workaround. And in the future we should try to increase insiders coverage to hopefully find issues like this earlier

[winzig]

Thanks guys, I was one of those users, and can confirm the latest code-insiders is working fine.

[winzig]

I take it back, still experiencing it. However, I'm going to assume at this point that the update I picked up today is not the update discussed above.

[isidorn]

@winzig if you got a stable update today - that one does not inclue the fix.
The latest vscode insiders includes the fix. Can you please try insiders
edit: I just saw you tried insiders but 10 hours ago, the one with the fix was published a couple of hours ago, so can you plelase try again

[winzig]

@isidorn Yeah I was using code-insiders yesterday when I saw it, but today at any rate I'm fully updated on insiders again and cannot reproduce the issue, so appears to be working, thanks!

[isidorn]

After discussion we decided to have ths fix for our second stable recovery build which we plan to do next week.
Can you please verify with this build if your issue is fixed? Thanks a lot!
windows: download
mac: download
linux: download

[winzig]

@isidorn I installed the Mac version you listed and can confirm I am no longer experiencing this problem.

[NCC1701M]

I tested the Insider version. Looks good.

Thanks for the fast fix.

[weinand]

I've verified too that this works now.

[enesates]

Hi,

I updated VSCode yesterday. So, I am using 1.28.2 version on MacOs 10.13.6 and Prophet Debugger for Salesforce Commerce Cloud.

I have been getting Unable match cartridge: "null" error for some cartridges while debugging since yesterday. If I click the Restart button, it works well sometimes. I am not sure if it is related with this issue but wanted let you know.

[isidorn]

@enesates this is not related, please file this against the debug extension you are using. Thank you