Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: on restart, make sure to first disconnect and only then run th… #60787

Merged
merged 2 commits into from Oct 12, 2018

Conversation

isidorn
Copy link
Contributor

@isidorn isidorn commented Oct 12, 2018

Fixes the order in which prelaunch tasks are run on debug restart
More details in the attached issue
@joaomoreno please quickly review one more time since I had merge conflicts.

fixes #60593

Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joaomoreno joaomoreno added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 12, 2018
@isidorn isidorn merged commit 42a5edf into release/1.28 Oct 12, 2018
@isidorn isidorn deleted the isidorn/restartOrder branch October 12, 2018 14:52
@egamma egamma removed this from the September Recovery 2, 2018 milestone Oct 18, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants