-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaking notifications make VS Code freeze #62970
Comments
What were you doing before the hangs? I don't think the logs have any useful info besides this error which shows up many times after the hang message in one instance
@jrieken is there any way to tie this to issues we've looked at lately? |
Yeah, could be the memory/listener leak... Best is to try with latest insiders or 1.29 stable... |
Hi, I am also experiencing hang. VS Code version Version 1.29.0, macOS 10.13.6 (17G3025) But unfortunately, because the window was unresponsive, I cannot get developer tool to launch, so I did not get any CPU profiling. But I do have control over other VS Code windows running separately to the window that frozen. Will profiling other windows produce useful information? Also, during the hang, Code Helper spiked to 100%. |
1.29 stable with Windows 10 also experience this problem |
same here with Win 10 and 1.29.0 |
@sgyzetrov @joseph1125 @tomaxsas Only CPU profiling will help us understand this. If the hang is very bad, then restart VS Code, start dev tools and keep them in the background, and profile when the editor is unresponsive. |
Yeah...I did that, just now. After letting dev tool run in the background for more than 3 hrs, finally VS Code hang again (I was not even working on it, I was browsing Reddit on another macOS desktop), and this time, CPU profiler got stuck too. I clicked start (it then turned into a red 'stop'), I then let it run for 57 sec, nothing happened, so I clicked 'stop'. BUT then it just STUCK. There is no info coming up, I tried to start a new profile, but the button is a grey 'start'. And |
Had to force quit Code Helper and VS Code to let my fan slow down... |
Try to profile for much shorter then, 5-10 seconds and even then it can take a very long time to finally save the profile. |
I have also experienced this twice just now. |
I'm getting this severely too. Is there any way I can roll back to the previous version? |
@VishwaRajGit @tecosaur please help us profile this.
Thanks for your help. |
everyone also attach the list of extensions you are using, simply run |
@jrieken After vs code window was frozen, I was following the steps above and profiler just got into state shown below. I am still waiting for 'Save' to appear, but it seems never going to happen. I am on Windows 10 Pro
|
my vscode got hangs as well with new version in windows 10 my extensions: |
Same here. Happens every 10-15 minutes. |
Freeze quite frequently to me as well. VSCode Version: 1.29.0 Code Extensions:
|
Hi folks, It sees VS Code will reproduce this hang whenever it is not being worked on. Although strangely if your workspace only contains The window I got hang was the one I was editing @jrieken Johannes, I finally got the CPU profile. This time I profiled for 5 sec, after waiting for about 5 min I was able saved it. My extensions are listed below.
CPU profile with |
Similar to @sgyzetrov I've noticed VS Code reliably freezing if I switch focus to a different application and then come back to it. Attached is a CPU profile from the latest freeze. I only tabbed over to Safari for a few seconds. VSCode Version: 1.30.0-insider Installed Extensions
CPU profile with .txt extension added |
why hide my comment 😹 |
Freeze on fedora 29 also
My extensions:
I'm going to test insider version |
How to revert to previous version? |
@mateuszgazdziak do you have a lot |
Same here on Mac OSX Mojave, since the 1.29.0 update |
Was having same issue, latest insiders seems to have fixed it, thanks for working on that. |
VSCode v1.29.0. hangs on Mac OSX High Sierra 10.13.6. |
@bsendras Yeah, we already know that. We work full steam towards 1.29.1. In the meantime you can use insiders: http://code.visualstudio.com/insiders/ which already has the fix for this. |
@fusengine I work on Windows 10 :( |
#63214 I have problem with hangs too |
Same problem. This problem was in the insider version too. Why they released the stable version with this issue? |
That likely means that you don't have this issue but another issue. That's unhappy but we are here to help and fix. Please file a new issue, bonus points for providing version string, os, etc. Last, please following our perf guide: https://github.com/Microsoft/vscode/wiki/Performance-Issues |
When you fix that ? |
Still having the same issues after your very recent fix. Especially problematic when scrolling or getting new input in the integrated terminal. Also, switching from 'files' to 'search' causes a good lag(and about 25% cpu usage for a few secs) |
@oppoi1 This is about a memory leak that happens with uncleared notification. Your comment doesn't match that, so please file a new issue. Bonus points for following our guidelines: https://github.com/Microsoft/vscode/wiki/Performance-Issues |
Today this was happend when I pasted into JavaScript doc. sentence with spaces. I suppose the code validation system froze. |
This issue is about a very specific, fast growing, memory leak that happens when having notifications. We have released a fix for this issue in 1.29.1 and 1.30-insiders. Please make sure to be one of those or later versions. Different issues often show the same symptoms but the reverse if often not true. That means if you see a slowdown (symptom) it's very likely not this issue but another issue. Please try latest, please file new issues when an issue is closed, please follow this guide: https://github.com/Microsoft/vscode/wiki/Performance-Issues |
Several hangs in a row. Attached are the log files from two of the hangs which contain the error
[error] [VS Code]: detected unresponsive
.InsidersHangs.zip
The text was updated successfully, but these errors were encountered: