[Extension API] executeCommand 'editor.action.goToDeclaration' returns immediately

[jpoon]

Issue Type: Bug

I expected executeCommand to return once the goToDeclaration action has completed.

Sample Code:

    await vscode.commands.executeCommand('editor.action.goToDeclaration');
    console.log(vscode.window.activeTextEditor!.selection.start);
    await new Promise(resolve => setTimeout(resolve, 2000));
    console.log(vscode.window.activeTextEditor!.selection.start);

Console Output:

Object
line:502
character:15
Object
line:465
character:8

VS Code version: Code 1.30.1 (dea8705, 2018-12-18T18:12:07.165Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz (4 x 3400)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	15.93GB (8.72GB free)
Process Argv	.
Screen Reader	no
VM	0%

Extensions (5)

Extension	Author (truncated)	Version
python	ms-	2018.12.1
csharp	ms-	1.17.1
Go	ms-	0.8.0
vscode-docker	Pet	0.4.0
vim	vsc	0.17.2

[jrieken]

I expected executeCommand to return once the goToDeclaration action has completed.

It does but only when calling it with correct arguments. In this case the position is missing and will have gotten an error for that.

[vscodebot]

We have a great developer community over on slack where extension authors help each other. This is a great place for you to ask questions and find support.

Happy Coding!

[jpoon]

Do you have an example of how it should be called (ie. what are the correct arguments)? Don't see any docs or examples of a position being passed to goToDeclaration.

[jrieken]

Sorry, I had the wrong command in mind. Things should work the way you have written them. The editor must have a file open that supports go to declaration and it must not be an embedded editor, otherwise there are no restrictions.

[jpoon]

The editor must have a file open that supports go to declaration and it must not be an embedded editor, otherwise there are no restrictions.

Yes, and yes. It probably helps if I shared the file of where I ran goToDeclaration, but looking at the output I shared above, you'll see that the cursor does move, it just takes a couple seconds to resolve, and there's on way to await it.

[jrieken]

There is actually one level of promises that we don't await. I will push a fix